Skip to content

Fix hasChangesInDirectorySinceGitTag #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix hasChangesInDirectorySinceGitTag #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/repo.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,10 +175,7 @@ describe('repo', () => {
.calledWith('git', ['diff', 'v1.0.0', 'HEAD', '--name-only'], {
cwd: '/path/to/repo',
})
.mockResolvedValue([
'/path/to/repo/file1',
'/path/to/repo/subdirectory/file1',
]);
.mockResolvedValue(['file1', 'subdirectory/file1']);

const hasChanges = await hasChangesInDirectorySinceGitTag(
'/path/to/repo',
Expand All @@ -194,7 +191,7 @@ describe('repo', () => {
.calledWith('git', ['diff', 'v2.0.0', 'HEAD', '--name-only'], {
cwd: '/path/to/repo',
})
.mockResolvedValue(['/path/to/repo/file1', '/path/to/repo/file2']);
.mockResolvedValue(['file1', 'file2']);

const hasChanges = await hasChangesInDirectorySinceGitTag(
'/path/to/repo',
Expand Down
14 changes: 9 additions & 5 deletions src/repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import path from 'path';
import {
runCommand,
getStdoutFromCommand,
Expand Down Expand Up @@ -112,11 +113,14 @@ async function getFilesChangedSince(
repositoryDirectoryPath: string,
tagName: string,
): Promise<string[]> {
return await getLinesFromGitCommandWithin(repositoryDirectoryPath, 'diff', [
tagName,
'HEAD',
'--name-only',
]);
const partialFilePaths = await getLinesFromGitCommandWithin(
repositoryDirectoryPath,
'diff',
[tagName, 'HEAD', '--name-only'],
);
return partialFilePaths.map((partialFilePath) =>
path.join(repositoryDirectoryPath, partialFilePath),
);
}

/**
Expand Down