Skip to content

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Oct 12, 2022

  • Add a hashbang line to ensure that it will be executed with Node as per the instructions in the NPM docs
  • Ensure that the name of the executable is create-release-branch, not @metamask/create-release-branch

* Add a hashbang line to ensure that it will be executed with Node as
  per the [instructions in the NPM docs][1]
* Ensure that the name of the executable is `create-release-branch`, not
  `@metamask/create-release-branch`

[1]: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#bin
@mcmire mcmire requested a review from a team as a code owner October 12, 2022 17:31
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit d40d3f7 into main Oct 12, 2022
@mcmire mcmire deleted the fix-executable branch October 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants