Skip to content

chore: bump dependencies #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 27, 2023
Merged

chore: bump dependencies #79

merged 15 commits into from
Apr 27, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 26, 2023 •
edited
Loading

@socket-security
Copy link

socket-security bot commented Apr 26, 2023 •
edited
Loading

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
glob@10.2.2 filesystem, environment +6 isaacs
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@types/rimraf@4.0.5 3.0.2...4.0.5 None +0/-2 types
@metamask/utils@5.0.2 3.6.0...5.0.2 network +15/-0 metamaskbot
@types/which@3.0.0 2.0.2...3.0.0 None +0/-0 types

@legobeat legobeat marked this pull request as ready for review April 26, 2023 23:39
@legobeat legobeat requested a review from a team as a code owner April 26, 2023 23:39
@legobeat legobeat marked this pull request as draft April 27, 2023 00:14
legobeat added 7 commits April 27, 2023 11:10
@legobeat
deps: glob@8.0.3->10.2.2
0c11e07
@legobeat
deps: execa@5.0.0->7.1.1
159bd3e
@legobeat
deps: @metamask/utils@3.6.0->5.0.2
252ec79
@legobeat
devDeps: @lavamoat/allow-scripts@2.0.3->2.3.1
2f5278c
@legobeat
devDeps: jest@29.3.0->29.5.0
f9d98d9
@legobeat
devDeps: rimraf@3.0.2->4.0.5
584f1c4
@legobeat
tsconfig: set skipLibCheck = true
4fbfe78 
unblocks error:

node_modules/path-scurry/node_modules/lru-cache/dist/cjs/index.d.ts:244:15 - error TS2430: Interface 'FetchOptionsNoContext<K, V, FC>' incorrectly extends interface 'FetchOptions<K, V, FC>'.
  Types of property 'context' are incompatible.
    Type 'undefined' is not assignable to type 'FC'.
      'FC' could be instantiated with an arbitrary type which could be unrelated to 'undefined'.

244     interface FetchOptionsNoContext<K, V, FC> extends FetchOptions<K, V, FC> {
                  ~~~~~~~~~~~~~~~~~~~~~

Found 1 error in node_modules/path-scurry/node_modules/lru-cache/dist/cjs/index.d.ts:244
@legobeat legobeat marked this pull request as ready for review April 27, 2023 02:50
Gudahtt
Gudahtt reviewed Apr 27, 2023
View reviewed changes
tsconfig.json
"moduleResolution": "node",
"noEmit": true,
"noErrorTruncation": true,
"skipLibCheck": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. It's a shame to disable type checking for libraries. I see that you found an error that there is no apparently solution for though. I guess we can use this as a workaround in the meantime.

Gudahtt
Gudahtt approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 03ee8fd into MetaMask:main Apr 27, 2023
@legobeat legobeat deleted the deps-bumps branch June 16, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Gudahtt