Skip to content

Conversation

legobeat
Copy link

@legobeat legobeat commented Jan 23, 2024

  • Update @metamask/ethjs-rpc from ^0.3.1 to ^0.4.0

Changed

  • BREAKING: @babel/runtime@^7.0.0 is now a peerDependency (#34)
  • Update babel from 6.18.2 to 7.2 (#34)

This is the last missing piece for fully removing babel v6 as peer/runtime dependency for this package.

@metamask/ethjs-query itself has migrated to babel7 so the new peerDependency for @metamask/ethjs-rpc is not breaking, here.

Blocking

Copy link

socket-security bot commented Jan 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/cli@7.23.4 Transitive: environment, eval, filesystem, network, shell, unsafe +70 12 MB nicolo-ribaudo
npm/@babel/core@7.23.7 environment, filesystem, unsafe Transitive: shell +51 10.8 MB nicolo-ribaudo
npm/@babel/eslint-parser@7.23.3 unsafe Transitive: environment, eval, filesystem, shell +141 22.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-arrow-functions@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-block-scoped-functions@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-block-scoping@7.23.4 Transitive: environment, filesystem, shell, unsafe +53 10.9 MB nicolo-ribaudo
npm/@babel/plugin-transform-classes@7.23.8 Transitive: environment, filesystem, shell, unsafe +57 11 MB nicolo-ribaudo
npm/@babel/plugin-transform-computed-properties@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-destructuring@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.9 MB nicolo-ribaudo
npm/@babel/plugin-transform-for-of@7.23.6 Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-function-name@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-literals@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-member-expression-literals@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-modules-commonjs@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-object-super@7.23.3 Transitive: environment, filesystem, shell, unsafe +56 10.9 MB nicolo-ribaudo
npm/@babel/plugin-transform-parameters@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-property-literals@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-shorthand-properties@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-spread@7.23.3 Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-sticky-regex@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-template-literals@7.23.3 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/plugin-transform-unicode-regex@7.23.3 Transitive: environment, filesystem, shell, unsafe +64 11.1 MB nicolo-ribaudo
npm/@babel/register@7.23.7 environment, filesystem, unsafe Transitive: shell +72 11.9 MB nicolo-ribaudo
npm/@babel/runtime@7.23.8 None +1 274 kB nicolo-ribaudo
npm/@metamask/ethjs-rpc@0.4.0 None +5 367 kB metamaskbot
npm/chai@4.4.1 None +7 923 kB keithamus
npm/eslint-import-resolver-webpack@0.2.5 filesystem Transitive: environment, eval, shell, unsafe +196 21 MB benmosher
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: environment, eval, shell +183 20.9 MB ljharb
npm/eslint@5.16.0 filesystem, unsafe Transitive: environment, eval, shell +104 15.7 MB eslint

🚮 Removed packages: npm/@babel/cli@7.23.0, npm/@babel/code-frame@7.22.13, npm/@babel/compat-data@7.23.2, npm/@babel/core@7.23.2, npm/@babel/eslint-parser@7.22.15, npm/@babel/generator@7.23.0, npm/@babel/helper-compilation-targets@7.22.15, npm/@babel/helper-module-transforms@7.23.0, npm/@babel/helper-string-parser@7.22.5, npm/@babel/helper-validator-option@7.22.15, npm/@babel/helpers@7.23.2, npm/@babel/highlight@7.22.20, npm/@babel/parser@7.23.0, npm/@babel/plugin-transform-arrow-functions@7.22.5, npm/@babel/plugin-transform-block-scoped-functions@7.22.5, npm/@babel/plugin-transform-block-scoping@7.23.0, npm/@babel/plugin-transform-classes@7.22.15, npm/@babel/plugin-transform-computed-properties@7.22.5, npm/@babel/plugin-transform-destructuring@7.23.0, npm/@babel/plugin-transform-for-of@7.22.15, npm/@babel/plugin-transform-function-name@7.22.5, npm/@babel/plugin-transform-literals@7.22.5, npm/@babel/plugin-transform-member-expression-literals@7.22.5, npm/@babel/plugin-transform-modules-commonjs@7.23.0, npm/@babel/plugin-transform-object-super@7.22.5, npm/@babel/plugin-transform-parameters@7.22.15, npm/@babel/plugin-transform-property-literals@7.22.5, npm/@babel/plugin-transform-shorthand-properties@7.22.5, npm/@babel/plugin-transform-spread@7.22.5, npm/@babel/plugin-transform-sticky-regex@7.22.5, npm/@babel/plugin-transform-template-literals@7.22.5, npm/@babel/plugin-transform-unicode-regex@7.22.5, npm/@babel/register@7.22.15, npm/@babel/runtime@7.23.2, npm/@babel/traverse@7.23.2, npm/@babel/types@7.23.0, npm/@jridgewell/trace-mapping@0.3.20, npm/@metamask/ethjs-rpc@0.3.1, npm/@types/json-schema@7.0.14, npm/assert@1.5.0, npm/async-each@1.0.1, npm/axe-core@4.7.0, npm/babel-code-frame@6.26.0, npm/balanced-match@1.0.0, npm/binary-extensions@1.11.0, npm/browserslist@4.22.1, npm/buffer-from@1.0.0, npm/caller-path@0.1.0, npm/callsites@0.2.0, npm/caniuse-lite@1.0.30001554, npm/chai@4.3.10, npm/chardet@0.4.2, npm/chokidar@3.5.3, npm/circular-json@0.3.3, npm/component-emitter@1.3.0, npm/core-util-is@1.0.2, npm/d@1.0.0, npm/deep-is@0.1.3, npm/des.js@1.0.1, npm/electron-to-chromium@1.4.567, npm/es5-ext@0.10.41, npm/es6-set@0.1.5, npm/es6-symbol@3.1.1, npm/eslint-import-resolver-webpack@0.2.4, npm/eslint-plugin-import@2.29.0, npm/eslint@5.4.0, npm/espree@4.1.0, npm/esutils@2.0.2, npm/external-editor@2.2.0, npm/file-entry-cache@2.0.0, npm/flat-cache@1.3.4, npm/fsevents@2.3.3, npm/function-bind@1.1.1, npm/graceful-fs@4.1.11, npm/has-ansi@2.0.0, npm/has@1.0.3, npm/inquirer@5.2.0, npm/interpret@1.1.0, npm/is-accessor-descriptor@0.1.6, npm/is-core-module@2.11.0, npm/is-data-descriptor@0.1.4, npm/is-descriptor@0.1.6, npm/is-resolvable@1.1.0, npm/lodash@4.17.21, npm/next-tick@1.0.0, npm/node-releases@2.0.13, npm/object.assign@4.1.4, npm/optionator@0.8.2, npm/pako@1.0.11, npm/pluralize@7.0.0, npm/process-nextick-args@2.0.0, npm/querystring@0.2.0, npm/readable-stream@2.3.5, npm/readdirp@3.6.0, npm/regenerate-unicode-properties@10.1.1, npm/regenerator-runtime@0.14.0, npm/repeat-element@1.1.2, npm/require-uncached@1.0.3, npm/resolve-from@1.0.1, npm/rxjs@5.5.12, npm/safe-array-concat@1.0.1, npm/safe-buffer@5.1.1, npm/safe-regex-test@1.0.0, npm/set-function-length@1.1.1, npm/slice-ansi@1.0.0, npm/spdx-correct@3.1.1, npm/spdx-license-ids@3.0.12, npm/string_decoder@1.0.3, npm/symbol-observable@1.0.1, npm/table@4.0.3, npm/tsconfig-paths@3.14.2, npm/url@0.11.0, npm/which-module@2.0.0, npm/which@1.3.0, npm/write@0.2.1

View full report↗︎

Copy link

socket-security bot commented Jan 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@aashutoshrathi/word-wrap@1.2.6, npm/@babel/cli@7.23.4, npm/@babel/code-frame@7.23.5, npm/@babel/compat-data@7.23.5, npm/@babel/core@7.23.7, npm/@babel/eslint-parser@7.23.3, npm/@babel/generator@7.23.6, npm/@babel/helper-compilation-targets@7.23.6, npm/@babel/helper-module-transforms@7.23.3, npm/@babel/helper-string-parser@7.23.4, npm/@babel/helper-validator-option@7.23.5, npm/@babel/helpers@7.23.8, npm/@babel/highlight@7.23.4, npm/@babel/parser@7.23.6, npm/@babel/plugin-transform-arrow-functions@7.23.3, npm/@babel/plugin-transform-block-scoped-functions@7.23.3, npm/@babel/plugin-transform-block-scoping@7.23.4, npm/@babel/plugin-transform-classes@7.23.8, npm/@babel/plugin-transform-computed-properties@7.23.3, npm/@babel/plugin-transform-destructuring@7.23.3, npm/@babel/plugin-transform-for-of@7.23.6, npm/@babel/plugin-transform-function-name@7.23.3, npm/@babel/plugin-transform-literals@7.23.3, npm/@babel/plugin-transform-member-expression-literals@7.23.3, npm/@babel/plugin-transform-modules-commonjs@7.23.3, npm/@babel/plugin-transform-object-super@7.23.3, npm/@babel/plugin-transform-parameters@7.23.3, npm/@babel/plugin-transform-property-literals@7.23.3, npm/@babel/plugin-transform-shorthand-properties@7.23.3, npm/@babel/plugin-transform-spread@7.23.3, npm/@babel/plugin-transform-sticky-regex@7.23.3, npm/@babel/plugin-transform-template-literals@7.23.3, npm/@babel/plugin-transform-unicode-regex@7.23.3, npm/@babel/register@7.23.7, npm/@babel/runtime@7.23.8, npm/@babel/traverse@7.23.7, npm/@babel/types@7.23.6, npm/@eslint-community/eslint-utils@4.4.0, npm/@eslint-community/regexpp@4.10.0, npm/@eslint/eslintrc@2.1.4, npm/@eslint/js@8.56.0, npm/@humanwhocodes/config-array@0.11.14, npm/@humanwhocodes/module-importer@1.0.1, npm/@humanwhocodes/object-schema@2.0.2, npm/@jridgewell/trace-mapping@0.3.22, npm/@metamask/ethjs-rpc@0.4.0, npm/@nodelib/fs.scandir@2.1.5, npm/@nodelib/fs.stat@2.0.5, npm/@nodelib/fs.walk@1.2.8, npm/@types/json-schema@7.0.15, npm/@ungap/structured-clone@1.2.0, npm/acorn@8.11.3, npm/ansi-regex@5.0.1, npm/argparse@2.0.1, npm/assert@1.5.1, npm/astral-regex@1.0.0, npm/async-each@1.0.6, npm/balanced-match@1.0.2, npm/binary-extensions@1.13.1, npm/browserslist@4.22.2, npm/buffer-from@1.1.2, npm/callsites@3.1.0, npm/caniuse-lite@1.0.30001579, npm/chai@4.4.1, npm/chardet@0.7.0, npm/component-emitter@1.3.1, npm/core-util-is@1.0.3, npm/deep-is@0.1.4, npm/des.js@1.1.0, npm/doctrine@3.0.0, npm/electron-to-chromium@1.4.643, npm/es6-set@0.1.6, npm/escape-string-regexp@4.0.0, npm/eslint-import-resolver-webpack@0.2.5, npm/eslint-plugin-import@2.29.1, npm/eslint-scope@7.2.2, npm/eslint-visitor-keys@3.4.3, npm/eslint@5.16.0, npm/eslint@8.56.0, npm/espree@5.0.1, npm/espree@9.6.1, npm/esutils@2.0.3, npm/external-editor@3.1.0, npm/fastq@1.16.0, npm/file-entry-cache@5.0.1, npm/file-entry-cache@6.0.1, npm/flat-cache@2.0.1, npm/flat-cache@3.2.0, npm/flatted@2.0.2, npm/flatted@3.2.9, npm/glob-parent@6.0.2, npm/globals@13.24.0, npm/graceful-fs@4.2.11, npm/graphemer@1.4.0, npm/ignore@5.3.0, npm/import-fresh@3.3.0, npm/inquirer@6.5.2, npm/interpret@1.4.0, npm/is-accessor-descriptor@1.0.1, npm/is-descriptor@0.1.7, npm/is-descriptor@1.0.3, npm/is-path-inside@3.0.3, npm/js-yaml@4.1.0, npm/json-buffer@3.0.1, npm/keyv@4.5.4, npm/levn@0.4.1, npm/lodash.merge@4.6.2, npm/node-releases@2.0.14, npm/object.assign@4.1.5, npm/optionator@0.8.3, npm/optionator@0.9.3, npm/parent-module@1.0.1, npm/prelude-ls@1.2.1, npm/process-nextick-args@2.0.1, npm/punycode@2.3.1, npm/queue-microtask@1.2.3, npm/readable-stream@2.3.8, npm/regenerator-runtime@0.14.1, npm/repeat-element@1.1.4, npm/resolve-from@4.0.0, npm/reusify@1.0.4, npm/run-parallel@1.2.0, npm/rxjs@6.6.7, npm/safe-array-concat@1.1.0, npm/safe-buffer@5.1.2, npm/safe-regex-test@1.0.2, npm/set-function-length@1.2.0, npm/slice-ansi@2.1.0, npm/spdx-correct@3.2.0, npm/spdx-license-ids@3.0.16, npm/strip-ansi@6.0.1, npm/strip-json-comments@3.1.1, npm/table@5.4.6, npm/tsconfig-paths@3.15.0, npm/tslib@1.14.1, npm/type-check@0.4.0, npm/type-fest@0.20.2, npm/url@0.11.3, npm/util@0.10.4, npm/which-module@2.0.1, npm/word-wrap@1.2.5, npm/write@1.0.3

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Author

@SocketSecurity ignore-all

these are actually not related to this PR (and fine)

@legobeat legobeat requested review from naugtur, kumavis, leotm, NicholasEllul and a team January 24, 2024 00:05
@legobeat legobeat marked this pull request as ready for review January 24, 2024 00:05
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jan 24, 2024
@legobeat legobeat force-pushed the deps-ethjs-rpc branch 2 times, most recently from d5e2b1e to 3cc6f19 Compare January 24, 2024 00:35
@legobeat legobeat mentioned this pull request Jan 24, 2024
2 tasks
@legobeat legobeat requested review from Mrtenz and a team January 24, 2024 09:51
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit f357dc3 into MetaMask:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants