This repository was archived by the owner on Nov 9, 2023. It is now read-only.
4.0.0 #29
Merged
4.0.0 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcmire
reviewed
Oct 3, 2022
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Gudahtt
reviewed
Oct 4, 2022
| @@ -6,9 +6,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [4.0.0] - 2022-10-03 | |||
| ### Changed | |||
There was a problem hiding this comment.
This PR is missing: #15
Specifically, the change in minimum supported Node.js version is notable, because it's a breaking change.
There was a problem hiding this comment.
Whoops, I missed this one. Might be good then to add something like:
- Add Node 12 as minimum required version [#15](https://github.com/MetaMask/json-rpc-middleware-stream/pull/15)
right before
- Retry pending requests when notification to reconnect is received ([#27](https://github.com/MetaMask/json-rpc-middleware-stream/pull/27))
?
There was a problem hiding this comment.
Looks good, except it should be prefixed with "BREAKING:"
There was a problem hiding this comment.
@jpuri could you add the "BREAKING:" prefix, so that people know which change is breaking?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 4.0.0.