This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
HW refactor #226
Draft
HW refactor #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bergarces
commented
Nov 14, 2022
•
bergarces
commented
- Imports latest changes from keyring controller, trezor and ledger keyrings and re-implements the bridge logic only.
- We should wait until packages are merged and added to the extension repo before merging.
bergarces
force-pushed
the
trezor-refactor-inheritance
branch
2 times, most recently
from
093e114 to
f8acefe
Compare
bergarces
force-pushed
the
trezor-refactor-inheritance
branch
from
f8acefe to
ee593d7
Compare
bergarces
force-pushed
the
trezor-refactor-inheritance
branch
from
ee593d7 to
99c6497
Compare
* chore: first commit * fix: circleci 2 * fix: circleci 3 * fix: circleci 4 * fix: circleci 5 * fix: circle 6 * temp * temp 3 * temp 4 * temp 5 * temp 7 * temp 8 * temp 9 * temp 10 * temp 11 * temp 12 * temp 13 * temp 14 * fix. config.yml * update: config.yml * update: config.yml * update: config.yml * Updated config.yml * fix: config.yml * fix: lint * fix: lint * fix: lint * move playwright in monorepo * update package.json and README * update config.yml * fix rebase error * fix pipeline issues * fix config.yml * fix config.yml and test * debug pipeline * refactor code * fix circleci * check screenshots * check screenshots * code refactor * clean code * remove white spaces * PR comments fix * update test * fix issue in ci * fix MM e2e * fix lint * fix UTs * fix uts * fix dir mapping clashing in test circleci * Fix minor issues after rebase Update Playwright README. Add example env file. Fix linting issues. * Fix moving builds in CI * remove log file Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
We need a .env for e2e tests because whenever we want to change the electron app entry path, we need to change the ELECTRON_APP_PATH env var for the e2e tests. If that var only exists on the CI, then updating it will: - allow the branch that changes the entry path to pass - fail all other branches For that reason we need to specify the entry path on the branch itself.
stop rewriting policy.json when running the app
dudeNitin
approved these changes
Jun 1, 2023
|
trezor-refactor-inheritance |
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 3 committers have signed the CLA. |
|
*I have read the CLA Document and I hereby sign the CLA*
…On Sun, 18 Jun, 2023, 04:01 Mentado111, ***@***.***> wrote:
trezor-refactor-inheritance
—
Reply to this email directly, view it on GitHub
<#226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAHM7KZRBIARIDEXOYP5HVTXLYV5RANCNFSM6AAAAAAR74B4A4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.