separate pinning and unpinning

MetaMask · Dec 11, 2023 · afa7237 · afa7237
1 parent b95cb42
commit afa7237
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/ui/components/multichain/account-list-item-menu/account-list-item-menu.js b/ui/components/multichain/account-list-item-menu/account-list-item-menu.js
@@ -125,11 +125,15 @@ export const AccountListItemMenu = ({
     };
   }, [handleClickOutside]);
 
-  const handlePinningToggle = (address, pin) => {
-    const updatedPinnedAccountList = pin
-      ? pinnedAccountList.filter((item) => item !== address)
-      : [...pinnedAccountList, address];
+  const handlePinning = (address) => {
+    const updatedPinnedAccountList = [...pinnedAccountList, address];
+    dispatch(updateAccountsList(updatedPinnedAccountList));
+  };
 
+  const handleUnpinning = (address) => {
+    const updatedPinnedAccountList = pinnedAccountList.filter(
+      (item) => item !== address,
+    );
     dispatch(updateAccountsList(updatedPinnedAccountList));
   };
 
@@ -163,7 +167,9 @@ export const AccountListItemMenu = ({
             <MenuItem
               data-testid="account-list-menu-pin"
               onClick={() => {
-                handlePinningToggle(identity.address, isPinned);
+                isPinned
+                  ? handleUnpinning(identity.address)
+                  : handlePinning(identity.address);
                 onClose();
               }}
               iconName={isPinned ? IconName.Unpin : IconName.Pin}