Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement integration test for contract interaction header and title #23948

Closed
pedronfigueiredo opened this issue Apr 10, 2024 · 0 comments · Fixed by #25981
Closed

Implement integration test for contract interaction header and title #23948

pedronfigueiredo opened this issue Apr 10, 2024 · 0 comments · Fixed by #25981
Assignees
@pnarayanaswamy
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead

Comments

@pedronfigueiredo
Copy link
Contributor

pedronfigueiredo commented Apr 10, 2024 •
edited
Loading

  • Create a contract interaction,
  • Assert the title and subtitle,
  • Assert the header details,
  • Click the information icon and assert that the appropriate section appear,
  • Click the advanced details icon and assert that the section appears.

Screenshots

Image

Image
@pedronfigueiredo pedronfigueiredo added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 10, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Apr 10, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@pedronfigueiredo pedronfigueiredo changed the title [Tech Task] Implement end to end tests for contract interaction Implement end to end tests for contract interaction Jul 2, 2024
@pedronfigueiredo pedronfigueiredo changed the title Implement end to end tests for contract interaction Implement e2e test for contract interaction header and title Jul 2, 2024
@pedronfigueiredo pedronfigueiredo changed the title Implement e2e test for contract interaction header and title Implement integration test for contract interaction header and title Jul 12, 2024
@pnarayanaswamy pnarayanaswamy self-assigned this Jul 17, 2024
@pnarayanaswamy pnarayanaswamy mentioned this issue Jul 22, 2024
Merged
7 tasks
cryptotavares pushed a commit that referenced this issue Jul 31, 2024
@pnarayanaswamy
test: header integration test for contract interaction (#25981)
e6955d7 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25981?quickstart=1)

## **Related issues**

Fixes:
[#23948](#23948)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 31, 2024
dawnseeker8 pushed a commit that referenced this issue Aug 12, 2024
@pnarayanaswamy @dawnseeker8
test: header integration test for contract interaction (#25981)
ed7fb55 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25981?quickstart=1)

## **Related issues**

Fixes:
[#23948](#23948)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnarayanaswamy pnarayanaswamy

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: header integration test for contract interaction MetaMask/metamask-extension
5 participants
@gauthierpetetin @pedronfigueiredo @cryptotavares @pnarayanaswamy @metamaskbot