Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Accounts - All Permissions screens are displayed in full width when we are in the extension window view #25678

Closed
seaona opened this issue Jul 4, 2024 · 4 comments · Fixed by #25870
Closed

[Bug]: Accounts - All Permissions screens are displayed in full width when we are in the extension window view #25678

seaona opened this issue Jul 4, 2024 · 4 comments · Fixed by #25870
Labels
regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 regression-RC-12.0.0 release-12.3.0 Issue or pull request that will be included in release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug won't fix

Comments

@seaona
Copy link
Contributor

seaona commented Jul 4, 2024

Describe the bug

All Permissions screens are displayed in full width when we are in the extension window view.
Relates to #25658

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-07-04 12-53-05

Screenshot from 2024-07-04 12-53-21

Screenshot from 2024-07-04 12-53-28

Steps to reproduce

  1. Click Menu (3 dots)
  2. Click All Permissions
  3. See width from subsequent pages

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response
@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. regression-RC-12.0.0 labels Jul 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jul 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jul 10, 2024
@gauthierpetetin gauthierpetetin added team-confirmations Push issues to confirmations team team-wallet-ux and removed team-confirmations Push issues to confirmations team labels Jul 11, 2024
@sleepytanya sleepytanya added the regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 label Jul 16, 2024
@sleepytanya
Copy link
Contributor

Present in the v12.0.0 beta:

Screenshot 2024-07-15 at 22 02 26

@NidhiKJha NidhiKJha mentioned this issue Jul 16, 2024
Merged
7 tasks
@danjm
Copy link
Contributor

danjm commented Jul 17, 2024

@hesterbruikman why was the "won't fix" label added?

NidhiKJha added a commit that referenced this issue Jul 19, 2024
@NidhiKJha
fix: fixed max width for permissions page (#25870)
61c7d16 
For full screen view, the permissions page width should follow the page
size what we have for other screens

## **Related issues**

Fixes: #25678 

## **Manual testing steps**

1. Go to Full Screen View
2. Go to Permissions Page
3. Check the Permissions Page has same width as the other pages

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
![Screenshot 2024-07-16 at 6 30
05 PM](https://github.com/user-attachments/assets/09de7ac4-ec50-4fb0-bea2-0f489e9d3164)


### **After**
![Screenshot 2024-07-16 at 6 26
32 PM](https://github.com/user-attachments/assets/ee9d0ccd-17dd-4283-a305-d77787c4673e)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jul 19, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
NidhiKJha added a commit that referenced this issue Jul 19, 2024
@NidhiKJha
fix: fixed max width for permissions page (#25870)
cdaf104 
For full screen view, the permissions page width should follow the page
size what we have for other screens

## **Related issues**

Fixes: #25678 

## **Manual testing steps**

1. Go to Full Screen View
2. Go to Permissions Page
3. Check the Permissions Page has same width as the other pages

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
![Screenshot 2024-07-16 at 6 30
05 PM](https://github.com/user-attachments/assets/09de7ac4-ec50-4fb0-bea2-0f489e9d3164)


### **After**
![Screenshot 2024-07-16 at 6 26
32 PM](https://github.com/user-attachments/assets/ee9d0ccd-17dd-4283-a305-d77787c4673e)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@NidhiKJha NidhiKJha mentioned this issue Jul 19, 2024
Merged
14 tasks
@sleepytanya
Copy link
Contributor

Latest v12.0.0 build #25098 (comment)

Screenshot 2024-07-25 at 16 14 00

@sleepytanya sleepytanya reopened this Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Jul 25, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jul 26, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jul 26, 2024
@sleepytanya sleepytanya reopened this Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Jul 26, 2024
@hesterbruikman
Copy link

Issue resolved in this PR

Added won't fix initially as we're not prioritising the full screen view at the moment. Regardless, happy this was fixed!

@danjm danjm closed this as completed in cea988a Aug 15, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-beta-12.0.0 Regression bug that was found in beta in release 12.0.0 regression-RC-12.0.0 release-12.3.0 Issue or pull request that will be included in release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug won't fix
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed max width for permissions page MetaMask/metamask-extension
6 participants
@gauthierpetetin @danjm @hesterbruikman @metamaskbot @seaona @sleepytanya