[Bug]: Contract Interactions - Cannot confirm a contract interaction with Ledger with the new redesign #27240
Assignees
Labels
area-hardware
regression-RC-12.3.0
Regression bug that was found in release candidate (RC) for release 12.3.0
release-12.5.0
Issue or pull request that will be included in release 12.5.0
release-12.6.0
Issue or pull request that will be included in release 12.6.0
release-blocker
This bug is blocking the next release
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Comments
seaona
added
type-bug
area-hardware
release-blocker
metamaskbot
added
the
regression-RC-12.3.0
gauthierpetetin
added
the
Sev2-normal
7 tasks
7 tasks
metamaskbot
added
the
release-12.6.0
OGPoyraz
added a commit
that referenced
this issue
Sep 23, 2024
… `Ledger` with the new redesign (#27331) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes the issue where confirm button is always disabled when contract interactions with Ledger account [](https://codespaces.new/MetaMask/metamask-extension/pull/27331?quickstart=1) Fixes: #27240 1. Activate Ledger account in MM 2. Go to uniswap 3. Try swapping from Sepolia eth to Weth 4. See confirmation "Confirm" button is not disabled https://github.com/user-attachments/assets/aba4e44c-049e-4d64-b14a-9bdc4c25a9cb <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
dbrans
pushed a commit
that referenced
this issue
Sep 23, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/27331?quickstart=1){kind=link}
… `Ledger` with the new redesign (#27331) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes the issue where confirm button is always disabled when contract interactions with Ledger account [](https://codespaces.new/MetaMask/metamask-extension/pull/27331?quickstart=1) ## **Related issues** Fixes: #27240 ## **Manual testing steps** 1. Activate Ledger account in MM 2. Go to uniswap 3. Try swapping from Sepolia eth to Weth 4. See confirmation "Confirm" button is not disabled ## **Screenshots/Recordings** https://github.com/user-attachments/assets/aba4e44c-049e-4d64-b14a-9bdc4c25a9cb ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.5.0
|
Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27331 which has this release label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Cannot confirm a contract interaction with a ledger account when the redesign is ON. The confirm button is always disabled
Expected behavior
No response
Screenshots/Recordings
contract-int-redesign-ledger.mp4
Steps to reproduce
Error messages or log output
No response
Detection stage
During release testing
Version
12.3.0
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: