Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding copy to SRP import screen to warn users #12400

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

VSaric
Copy link
Contributor

@VSaric VSaric commented Oct 19, 2021

Description:
Adding copy to SRP import screen to warn users that there current wallet will be replaced.

Screenshot:
Screenshot from 2021-10-20 10-05-40

@VSaric VSaric self-assigned this Oct 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@VSaric
Copy link
Contributor Author

VSaric commented Oct 19, 2021

#12343

Add copy to SRP import screen to warn users that there current wallet will be replaced.

@VSaric VSaric requested review from david0xd and removed request for david0xd October 19, 2021 14:24
@ghost
Copy link

ghost commented Oct 19, 2021

Verified by QA

@VSaric VSaric requested review from a team, NiranjanaBinoy and david0xd and removed request for a team October 20, 2021 06:52
@VSaric VSaric marked this pull request as ready for review October 20, 2021 06:53
@VSaric VSaric requested a review from a team as a code owner October 20, 2021 06:53
Copy link
Contributor

@david0xd david0xd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danjm danjm merged commit 5fea5fa into MetaMask:develop Oct 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants