Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v10.8.0 RC #12935

Merged
merged 101 commits into from
Dec 9, 2021
Merged

Version v10.8.0 RC #12935

merged 101 commits into from
Dec 9, 2021

Commits on Nov 17, 2021

  1. Remove unused background API methods (#12731)

    These background API methods were not used anywhere in the UI. One of
    them was called in `actions.js` by a function that itself was never
    called, so it have been removed. Additionally, one unused `actions.js`
    function was found and removed as well.
    
    `setAdvancedGasFee` is the only unused background method that remains.
    It was recently added and will be used in the near future.
    Gudahtt committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cce2dda View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Adding edit gas fee modal (#12624)

    Edit transaction screen changes for EIP-1559 V2
    jpuri committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0daefe9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6d35d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c6fb06 View commit details
    Browse the repository at this point in the history
  4. ci - fix yarn-audit (#12738)

    * ci/yarn-audit - ensure error propagation
    
    * ci/yarn-audit - ensure dependencies are installed first
    kumavis committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    f5f2f38 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa25eb1 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    d2617e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ec2af0 View commit details
    Browse the repository at this point in the history
  3. Update improved-yarn-audit and ignore 2 advisories (#12765)

    `improved-yarn-audit` has been updated so that it supports GitHub
    advisories. Two new GitHub advisories have been ignored, as they are
    both moderate RegExp DoS vulnerabilities that don't affect us, and they
    are embedded deep within our dependency graph and are difficult to
    update.
    Gudahtt committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    fb63754 View commit details
    Browse the repository at this point in the history
  4. Fix: eth_sign does not validate input (#12679)

    * Fix #5039
    
    * Converted function into async
    
    * Added more explicit explanation of why the number of bits for EcSign
    
    * eth_sign and eth_personalSign now report errors correctly back to the user
    
    * Added leeway to unsigned message byte check
    
    * Fix lint
    ritave committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    3f3479b View commit details
    Browse the repository at this point in the history
  5. Add CollectiblesController & CollectibleDetectionController (#12443)

    * Add CollectiblesController
    
    * bump controllers version
    
    * add CollectibleDetectionController
    
    * adapt to ERC1155 support changes in CollectiblesController
    
    * update @metamask/controllers to v20.0.0
    
    * update lavamoat policy files
    
    * put collectibleDetectionController instantiation behind feature flag
    adonesky1 committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    b119b77 View commit details
    Browse the repository at this point in the history
  6. Improve code fence transform error handling (#12742)

    This PR improves the error handling of the code fence removal transform stream by catching errors thrown by the `removeFencedCode` function and passing them to the `end` callback. This appears to resolve a problem where watched builds would blow up whenever a file with fences was reloaded.
    rekmarks committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    d89e533 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c9baf39 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. fix issue where contractExchangeRates are not available in swaps cont…

    …roller, make token address matching case insensitive (#12770)
    adonesky1 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    6838a3d View commit details
    Browse the repository at this point in the history
  2. Increase friction to bypass estimated revert (#12576)

    * If a transaction would revert/fail,
        1. hide the gas estimate info.
        2. Disable the confirm button.
        3. All user to enable the confirm button anyways.
        4. Do not show the default Transaction error message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Always return a value for hasSimulationError
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Use primary button of action message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Remove hasSimulationError from getErrorKey
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Move confirm anyways logic to base component.
    Change message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Disable edit if there's simulation error
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * hide confirm anyways button once clicked.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Move Actionable Primary Action to flex-end
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Fix unit tests
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Fix nested ternary lint issues
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * add !confirmAnyways to conditions to show GasDetails.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * ConfirmAnyways should be read from state
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Rename tryAnywayOption
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Remove await tick
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint issue fix
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes after rebase
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * description should show that it's content being tested.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * If a transaction would revert/fail,
        1. hide the gas estimate info.
        2. Disable the confirm button.
        3. All user to enable the confirm button anyways.
        4. Do not show the default Transaction error message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Always return a value for hasSimulationError
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Use primary button of action message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Remove hasSimulationError from getErrorKey
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Move confirm anyways logic to base component.
    Change message
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Disable edit if there's simulation error
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * hide confirm anyways button once clicked.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Move Actionable Primary Action to flex-end
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Fix unit tests
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Fix nested ternary lint issues
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * add !confirmAnyways to conditions to show GasDetails.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * ConfirmAnyways should be read from state
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Rename tryAnywayOption
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Remove await tick
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint issue fix
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes after rebase
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * description should show that it's content being tested.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Move simulation fails message inline with gas details component (#12705)
    
    * Move simulation fails message inline with gas details component
    
    * Remove old unit tests
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    
    * lint fix
    
    * use an XOR operation.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * The changes in this file are no longer needed because we hide the edit button now
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    segun and danjm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    143a5c4 View commit details
    Browse the repository at this point in the history
  3. Create an "Add a Nickname" popover (also support edit) #12528 (#12644)

    * added update nickname popover
    
    * fixed style errors
    
    * styling changes
    
    * fixed prettier error
    
    * added header
    
    * updates
    dragana8 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    367492a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    994a7d5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    74719a8 View commit details
    Browse the repository at this point in the history
  6. Ensure one and only one localhost option appears in network list (#12786

    )
    
    * Ensure one and only one localhost option appears in network list
    
    * Fix unit tests
    danjm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2647be9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #12772 from MetaMask/master-sync

    Sync `master` with `develop`
    ryanml committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0431821 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    42fea3d View commit details
    Browse the repository at this point in the history
  9. Remove localhost from default network list (#12790)

    * Remove localhost from default network list
    
    * Update e2e fixtures
    danjm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    d296c51 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ad41849 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. alert-circle-icon (#12651)

    EtDu committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    8ce0eff View commit details
    Browse the repository at this point in the history
  2. circle-icon (#12650)

    EtDu committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    49ae325 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #12793 from MetaMask/master-sync

    Sync `master` with `develop`
    ryanml committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    089afa6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf06025 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fbc6f4e View commit details
    Browse the repository at this point in the history
  6. Introduce QR based signer into MetaMask (#12065)

    * support qr based signer
    
    * add CSP for fire fox
    
    * get QR Hardware wallet name from device
    
    * fix qrHardware state missing in runtime
    
    * support qr based signer sign transaction
    
    * refine Request Signature modal ui
    
    * remove feature toggle
    
    * refine ui
    
    * fix notification is closing even there is a pending qr hardware transaction
    
    * add chinese translation, refine ui, fix qr process was breaking in some case
    
    * support import accounts by pubkeys
    
    * refine qr-based wallet ui and fix bugs
    
    * update @keystonehq/metamask-airgapped-keyring to fix that the signing hd path was inconsistent in some edge case
    
    * fix: avoid unnecessay navigation, fix ci
    
    * refactor qr-hardware-popover with @zxing/browser
    
    * update lavamoat policy, remove firefox CSP
    
    * refine qr reader ui, ignore unnecessary warning display
    
    * code refactor, use async functions insteads promise
    
    Co-authored-by: Soralit <soralitria@gmail.com>
    aaronisme and soralit committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    a931316 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    582882b View commit details
    Browse the repository at this point in the history
  8. Eip1559 v2 12593 (#12719)

    jpuri committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    f65063a View commit details
    Browse the repository at this point in the history
  9. ci - enforce yarn lock deduplications (#12737)

    * ci - test for yarn lock deduplications
    
    * deps - update yarn.lock and patches
    
    * lavamoat - update policy
    
    * test - ui/helpers/utils/optimism/buildUnserializedTransaction - test against json obj
    
    * lint fix
    
    * patch-package - patch @babel/runtime for lavamoat support
    
    * patch-package - fix additional @babel/runtime lockdown incompats
    
    * patch-package - cleanup sass patch
    kumavis committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d9d1a83 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dd77700 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Add storybook render tests with CI integration (#12477)

    * add storybook unit tests with CI integration
    
    * fix command and fix casing for test
    
    * change ci ordering for storybook tasks
    
    * fix syntax error
    
    * fix jest
    
    * lint
    
    * Add transaction-total-banner render test to Storybook (#12517)
    
    * transaction-total-banner
    
    * lint
    
    * confirm to spec
    
    * lint
    
    * fix jest ocnfig for snapshot test failure
    EtDu committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5a14a1a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb27e17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7609841 View commit details
    Browse the repository at this point in the history
  4. Clear the clipboard after the seed phrase is pasted (#12828)

    * Clear the clipboard after the seed phrase is pasted
    
    On the "Import" page of the import onboarding flow, we now clear the
    clipboard after the secret recovery phrase is pasted. This ensures that
    the SRP isn't accidentally pasted somewhere else by the user, which can
    be an easy and disastrous mistake to make.
    
    * Clear clipboard during new onboarding flow as well
    Gudahtt committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7929a92 View commit details
    Browse the repository at this point in the history
  5. Convert token input to BigNumber to handle decimals. (#12773)

    * Fixes #12762
    
    Adds a decimal length check for inputs and drops excess fractional part.
    Another edgecase not accounted for is when a token's decimal precision is 0 and attempting sending decimals will result in omitting the fractional part.
    
    * Change spies from sinon to jest and change onChange value to string.
    
    * Adjust
    
    * Remove sinon
    
    * Add test for issue case
    
    * DRY
    
    * Simplify logic by using BigNumber
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    tmashuang and danjm committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d179344 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7b8291 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    07f16d3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8721c80 View commit details
    Browse the repository at this point in the history
  9. Fix button-group.stories for new Storybook documentation (#12621)

    * button-group
    
    * remove usage table
    
    * Update ui/components/ui/button-group/button-group.component.js
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/ui/button-group/README.mdx
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/ui/button-group/README.mdx
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/ui/button-group/README.mdx
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/ui/button-group/README.mdx
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    EtDu and georgewrmarshall committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d5ba78f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1523b23 View commit details
    Browse the repository at this point in the history
  11. checkbox storybook (#12757)

    EtDu committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    02177c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Ignore sentry server errors in e2e tests (#12843)

    * Ignore sentry server errors in e2e tests
    
    * Update test/e2e/webdriver/driver.js
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    
    Co-authored-by: Dan J Miller <danjm.com@gmail.com>
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    3 people committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    1792a1e View commit details
    Browse the repository at this point in the history
  2. Sync develop with master (#12851)

    * Version v10.6.3
    
    * Fix "BigNumber Error: times() number type has more than 15 significant digits:" (#12802)
    
    * Bump @metmamask/logo to v3.1.1 (#12822)
    
    * Update changelog for v10.6.3
    
    * We shouldn't be changing decimal places as user type, we should do that on blur. (#12631)
    
    * We shouldn't be changing decimal places as user type, we should do that
    on blur.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Refactor code.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Linter fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Convert token input to BigNumber to handle decimals. (#12773)
    
    * Fixes #12762
    
    Adds a decimal length check for inputs and drops excess fractional part.
    Another edgecase not accounted for is when a token's decimal precision is 0 and attempting sending decimals will result in omitting the fractional part.
    
    * Change spies from sinon to jest and change onChange value to string.
    
    * Adjust
    
    * Remove sinon
    
    * Add test for issue case
    
    * DRY
    
    * Simplify logic by using BigNumber
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    
    * Update changelog
    
    * Ensure that handleChange in token-input.component handles empty values (#12835)
    
    Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
    Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
    Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com>
    Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com>
    5 people committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    57155dd View commit details
    Browse the repository at this point in the history
  3. Remove _removeBeforeUnload calls in confirm-encryption-public-key.com…

    …ponent.js and confirm-decrypt-message.component.js (#12825)
    danjm committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    74b3a3a View commit details
    Browse the repository at this point in the history
  4. Fix: markdown (#12861)

    0xdie committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    77d3f0a View commit details
    Browse the repository at this point in the history
  5. Sync master with develop (#12858)

    * Version v10.6.3
    
    * Fix "BigNumber Error: times() number type has more than 15 significant digits:" (#12802)
    
    * Bump @metmamask/logo to v3.1.1 (#12822)
    
    * Update changelog for v10.6.3
    
    * We shouldn't be changing decimal places as user type, we should do that on blur. (#12631)
    
    * We shouldn't be changing decimal places as user type, we should do that
    on blur.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Lint fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Refactor code.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Linter fixes.
    
    Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
    
    * Convert token input to BigNumber to handle decimals. (#12773)
    
    * Fixes #12762
    
    Adds a decimal length check for inputs and drops excess fractional part.
    Another edgecase not accounted for is when a token's decimal precision is 0 and attempting sending decimals will result in omitting the fractional part.
    
    * Change spies from sinon to jest and change onChange value to string.
    
    * Adjust
    
    * Remove sinon
    
    * Add test for issue case
    
    * DRY
    
    * Simplify logic by using BigNumber
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    
    * Update changelog
    
    * Ensure that handleChange in token-input.component handles empty values (#12835)
    
    * Version v10.6.4
    
    * update scams and network security risks link (#12752)
    
    * Ignore sentry server errors in e2e tests (#12843)
    
    * Ignore sentry server errors in e2e tests
    
    * Update test/e2e/webdriver/driver.js
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    
    Co-authored-by: Dan J Miller <danjm.com@gmail.com>
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    
    * Update changelog for v10.6.4
    
    Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
    Co-authored-by: Daniel <80175477+dan437@users.noreply.github.com>
    Co-authored-by: Olusegun Akintayo <akintayo.segun@gmail.com>
    Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com>
    Co-authored-by: Mingliang Liu <brightliu77@gmail.com>
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    7 people committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    91ceede View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Configuration menu
    Copy the full SHA
    35bab10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bed51b View commit details
    Browse the repository at this point in the history
  3. Adding collectibles items overview (#12506)

    * Adding collectibles items overview
    
    * addressing feedback
    
    Co-authored-by: Alex <adonesky@gmail.com>
    ryanml and adonesky1 committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    279c807 View commit details
    Browse the repository at this point in the history
  4. Fix environment variables used during test builds (#12855)

    The environment variables used for test builds was wrong for certain
    bundles because the `testing` flag wasn't passed through to the
    function that determines which environment variables to inject.
    Effectively this means that test builds on `master` were going to the
    production `metamask` Sentry project rather than the `test-metamask`
    project. This has been the case since #11080.
    
    The `testing` flag is now included for all bundles, and test builds now
    use the `test-metamask` Sentry project in all cases.
    Gudahtt committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    609f541 View commit details
    Browse the repository at this point in the history
  5. Feat/add collectible manually (#12834)

    * hook up add collectible manually flow
    
    * address feedback
    adonesky1 committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    5aa191f View commit details
    Browse the repository at this point in the history
  6. Fix LavaMoat background policy generation (#12844)

    The LavaMoat policy generation script would sporadically fail because
    it ran the build concurrently three times, and the build includes
    steps that delete the `dist` directory and write to it. So if one build
    process tried to write to the directory after another deleted it, it
    would fail.
    
    This was solved by adding a new `--policy-only` flag to the build
    script, and a new `scripts:prod` task. The `scripts:prod` task only
    runs the script tasks for prod, rather than the entire build process.
    The `--policy-only` flag stops the script tasks once the policy has
    been written, and stops any other files from being written to disk.
    
    This prevents the three concurrent build processes from getting in each
    others way, and it dramatically speeds up the process.
    Gudahtt committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    e8b7fcf View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    0e0e7ac View commit details
    Browse the repository at this point in the history
  2. Adds multilayer fee display to erc20 token approval screen (#12824)

    * Adds multilayer fee display to erc20 token approval screen
    
    * Change bold property name
    danjm committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c2ea04c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b975ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3f8cbd5 View commit details
    Browse the repository at this point in the history
  5. Removing un-necessary comma (#12883)

    * Confirm transaction screen style fixes
    jpuri committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    7ace049 View commit details
    Browse the repository at this point in the history
  6. Created a Nickname popover (#12632)

    * Created a Nickname popover
    
    * Fixing lines in index.scss
    
    * Handle copy button and fix some paddings
    
    * Added text to be editable in the storybook component
    
    * Simplify nickname scss and html
    
    * Delete harcoded address
    
    * Change color usage with new color system
    VSaric committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    35c1eaa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    76158bf View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Add support for eip-1559 on Trezor (#12627)

    * Add support for eip-1559 on Trezor
    
    * temp
    
    * Lint fix
    
    * Store trezor model type in background state instead attempting to get it in the frontend
    
    * code simplification
    
    * Temp update to eth-trezor-keyring version
    
    * Tempory update to eth-trezor-keyring version
    
    * Temp update to eth-trezor-keyring version
    
    * Fix display of hdpath selector in connect hardware flow for trezor
    
    * Updating the package version but we still need to run yarn setup and update the lockfile, once the package is updated
    
    * Update yarn.lock
    
    * Fix unit tests
    danjm committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    2856ea7 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary unlock step (#12840)

    As part of the unlock process, currently the seed phrase is retrieved
    from the background then discarded. This step is pointless, so it has
    been deleted.
    Gudahtt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    8835642 View commit details
    Browse the repository at this point in the history
  3. Format shared/modules/*.tests to use jest arrow functions and use str…

    …icter comparative matcher (#12908)
    tmashuang committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    b32bccc View commit details
    Browse the repository at this point in the history
  4. Remove invalid Jest storybook coverage config (#12846)

    The Jest storybook config was mistakenly set to overwrite the coverage
    report for our main set of Jest tests. It also had extremely high
    coverage thresholds set, and the `collectCoverageFrom` config was
    asking Jest to check that the storybook tests cover all of the UI code.
    
    For now the `collectCoverageFrom` config has been removed. I don't
    understand why we'd want to use Storybook to unit test in the first
    place, so I don't understand what parts of the codebase we'd want to
    cover with these tests. So for the moment, only the files touched by
    the current tests are considered.
    
    The coverage output directory is now set to `jest-coverage/storybook`
    so that it does not overlap with any other coverage reports.
    Gudahtt committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    d0c1fd7 View commit details
    Browse the repository at this point in the history
  5. Send all swaps requests to api2, remove useNewSwapsApi boolean (#12792)

    * Send all swaps requests to api2, remove useNewSwapsApi boolean
    
    * Switch token bucket priority
    
    * Fix tests
    
    * Trigger Build
    
    * Trigger Build
    meppsilon committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    8e6a0ff View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    a020281 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e25c34e View commit details
    Browse the repository at this point in the history
  3. add openSeaEnabled preference (#12909)

    * add openSeaEnabled preference
    
    * cleanup
    
    * add description copy
    adonesky1 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    3434b9f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    39d5afb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bbf4d23 View commit details
    Browse the repository at this point in the history
  6. Feat/collectibles display (#12873)

    * Wiring up Collectibles lists/items
    
    * wip
    
    * more wip
    
    * more more wip
    
    * yet more wip
    
    * wippp
    
    * more wipppp
    
    * closer
    
    * wroking
    
    * more wip
    
    * cleanup
    
    * cleanup
    
    * add-collectible form validation
    
    * update default ipfs-gateway
    
    * update refresh button
    
    * fix proptypes issue + add more padding to asset background
    
    * css tweaking
    
    * more cleanup
    
    * more cleanup
    
    * more cleanup
    
    * add migration
    
    * address feedback
    
    * fix migration + cleanup
    
    * bumping controllers version + adapting new collectiblesController shape
    
    * fix yarn dedupe
    adonesky1 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    81ea24f View commit details
    Browse the repository at this point in the history
  7. Swaps optimizations (#12842)

    * Trigger Build
    
    * Trigger Build
    
    * Move swaps index variables to redux
    
    * all optimizations so far
    
    * Add better equality checks for selectors in swaps index and build quote
    
    * Clean up PR, remove extra code and logs
    
    * Clean up lavamoat file
    
    * Fixes for optimizations
    
    * Update tests and test snapshots
    
    * Remove unnecessary tests
    
    * Remove unnecessary console log
    
    * Trigger Build
    
    * Trigger Build
    
    * Add delay to account for remote call made by trezor keyring
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    meppsilon and danjm committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    7a92e22 View commit details
    Browse the repository at this point in the history
  8. Implement Flask onboarding UI (#12745)

    * Added Flask Experimental Area warning to OnboardingV2
    
    * Added first time flow Flask Experimental Area warning
    
    * Made both onboarding flows use one Experimental Area component
    
    * Fix comments in React divs
    
    * Fix unreachable code
    
    * Fix build lint problems
    
    * Changes after code review
    
    * Added guards around route constants imports
    
    * Code Review changes
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Code review changes
    
    * Fix lint
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * Update ui/components/app/flask/experimental-area/index.scss
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    
    * fix lint
    
    Co-authored-by: George Marshall <george.marshall@consensys.net>
    ritave and georgewrmarshall committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    7038672 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #12917 from MetaMask/master-sync

    Sync develop with master
    Gudahtt committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    fb60b14 View commit details
    Browse the repository at this point in the history
  10. Feature: Transaction Insights (#12881)

    * integration for tx decoding confirmation and history view
    
    * upgrading @truffle/decoder to latest release 5.1.0
    
    * Update acorn and colors patches
    
    * feat: remove redundant styling
    
    * feat: basic integration for nickname components
    
    * feat: wiring functionality of adding new nickname
    
    * feat: wire functionality of showing nickname modal
    
    * feat: link the nickname popover with add/update popover
    
    * feat: moving forward with address nicknames integration
    
    * feat: fixing a bug related to passing chainId in addressBook
    
    * feat: populating memo prop in addressbook entry
    
    * feat: add explorer link
    
    * feat: bug fixing update nickname component
    
    * feat: fix proptypes
    
    * feat: adding tooltip for copying nickname address
    
    * featL fix styling for tx-details page
    
    * feat: optimize code for error handling
    
    * feat: limiting transaction decoding to tx with data
    
    * feat: remove tree UI component
    
    * feat: adding request to check for tx decoding supported networks
    
    * feat: showing data hex component
    
    * feat: fix react warnings
    
    * feat: remove extra margin in tx decoding
    
    * Remove unused package @truffle/source-map-utils
    
    * Ensure messages get translated
    
    * feat: link tx-decoding addresses with nicknames
    
    * Omit value for boolean attributes
    
    * Fix props reading in CopyRawData
    
    * fix: fixing issue with transaltion
    
    * Fix lint errors in TransactionDecoding
    
    - Remove unused import
    - Reorder imports
    - Address conflict between caught `error` and error state flag by
      renaming state flag to `hasError`
    - Fix requestUrl identifier casing and use of template string
    - Ensure `useEffect` gets passed the deps it needs
    - Add scope braces around case statement where it's needed
    - Omit literal `true` for boolean jsx attribute
    - Refactor nested ternary as `if` statements
    
    * fix: revert fetchWithCache modifications
    
    * Fix linting for TransactionListItemDetails
    
    - Remove unused import
    - Fix import spacing
    - Remove unused prop dereference
    - Fix string interpolation for translated From/To
    
    * Moving to popover pattern
    
    * fix: sass color variable
    
    * Omit value for boolean attribute
    
    * Remove changes from modal.js
    
    * fix: refactor nickname popovers
    
    * Ensure const gets declared before it's used
    
    * Fix linting for ConfirmTransactionBase
    
    - Remove unused prop chainId
    - Stop destructuring an unused field
    
    * fix: refactor usage of nicknames popovers in send-content-container
    
    * fix: remove extra prop updateAccountNicknameModal
    
    * fix: refactor code for address.component
    
    * fix: remove extra tooltip
    
    * Ensure NicknamePopovers always returns component
    
    * Fix linting for NicknamePopover component
    
    - Fix useCallback deps
    - Switch ternary to logical-or
    
    * Fix linting for SenderToRecipient
    
    ... by fixing import order
    
    * Remove unused addressCopied state
    
    * Delete empty file
    
    * fix: remove sender-to-recipient.container
    
    * fix: refactor usage of nickname popovers in confirm-page-container
    
    * fix: bug related to state variable
    
    * Stylelint fix
    
    * Lint fix
    
    * Change "Total Amount" to "Total"
    
    * Lint fix locales
    
    * Update address-book.spec.js
    
    * e2e test update
    
    * Update e2e tests
    
    * Fix issue where absence of function params in data hex tab would result in rendering a  string
    
    * Fix border radius, and width and height in small notification windows, of the update-nickname-popover
    
    * Remove fake await
    
    * Clean up
    
    * Clean up
    
    Co-authored-by: Alaa Hadad <alaahd@Alaas-MacBook-M1-Pro-14-inch.local>
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    Co-authored-by: g. nicholas d'andrea <gnidan@trufflesuite.com>
    4 people committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e056c88 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9babc8b View commit details
    Browse the repository at this point in the history
  12. Convert nonce background calls to async/await (#12853)

    The calls to the background in `actions.js` that relate to the custom
    nonce feature now use `async/await` and `promisifiedBackground`.
    
    The behaviour should be unchanged except that when setting the nonce
    field, the warning is shown in case of error before the loading
    indicator drops, which seems like it would be a minor improvement (if
    it has any user-facing impact at all).
    Gudahtt committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    b6b202c View commit details
    Browse the repository at this point in the history
  13. Update Jest coverage reporters (#12845)

    The coverage reporter for the console has been changed from `text` to
    `text-summary` because `text` was too long. It exceeded the maximum
    length of the CircleCI terminal output shown on their jobs page, making
    it very difficult to see why the unit test coverage job failed.
    
    The text summary only displays overall coverage metrics, but that is
    usually enough to indicate when the test fails due to a drop in
    coverage. The more detailed breakdown is still available as a HTML
    report linked in the `metamaskbot` comment, and in the `jest-coverage`
    directory when run locally.
    
    The three on-disk coverage reports used previously (`lcov`, `json`, and
    `clover`) have been replaced with just `html`. The HTML report was part
    of the `lcov` report, and it was the only one we were using.
    Gudahtt committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    267cdc4 View commit details
    Browse the repository at this point in the history
  14. Version v10.8.0

    metamaskbot committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    9262670 View commit details
    Browse the repository at this point in the history
  15. Update changelog for v10.8.0

    danjm committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    0563c47 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Revert "Feat/collectibles display (#12873)" (#12934)

    This reverts commit 81ea24f.
    adonesky1 authored and danjm committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3cff801 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b65005d View commit details
    Browse the repository at this point in the history
  3. Run yarn lavamoat:auto

    danjm committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5542bdd View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Update CHANGELOG.md

    Co-authored-by: Thomas Huang <tmashuang@users.noreply.github.com>
    danjm and tmashuang committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    5554ca5 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Tx insights fixes (#12988)

    * Ensure that function representation on hex and data tabs are consistent
    
    * Don't show redundant hex tab when deploying contract
    
    * Show standard pointer cursor on error messages in tx-decoder component
    
    * Don't show activity log for incoming transactions
    
    * Update localization
    
    * Fix error message
    danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    f56c25f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e57250f View commit details
    Browse the repository at this point in the history
  3. Tx decoding accreditation (#12918)

    * feature: adding support for truffle and etherscan accreditation
    
    * Fix scss linting
    
    * fix styling and classnames
    
    * Switch font size to rem
    
    * Update ui/components/app/transaction-decoding/components/ui/accreditation/accreditation.component.js
    
    Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
    
    * Update ui/components/app/transaction-decoding/components/ui/accreditation/index.scss
    
    Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
    
    * Update ui/components/app/transaction-decoding/components/ui/accreditation/accreditation.component.js
    
    Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
    
    * Update ui/components/app/transaction-decoding/components/ui/accreditation/accreditation.component.js
    
    Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
    
    * Fix linting
    
    Co-authored-by: g. nicholas d'andrea <gnidan@trufflesuite.com>
    Co-authored-by: Dan J Miller <danjm.com@gmail.com>
    Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
    Co-authored-by: g. nicholas d'andrea <gnidan@users.noreply.github.com>
    5 people committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    6adb48d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f4ce5bf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cc5cc2 View commit details
    Browse the repository at this point in the history
  6. Swaps UI redesign for the View Quote page (#12950)

    * Update EIP-1559 UI on the View Quote page (WIP)
    
    * UI redesign for the View Quote page in Swaps, update tests,  refactoring
    
    * Update styles for the View Quote page
    
    * Improve scrolling and styling for the View Quote page
    
    * Update snapshots
    
    * Fix a scrolling issue
    
    * Use Ethereum mainnet for swaps API calls if it's Rinkeby
    
    * UI / content updates on the View Quote page
    
    * Remove unused content in Swaps
    
    * Fix an ESLint issue
    
    * Update UTs with the latest content
    
    * Renaming
    
    * Remove 2 more unused content strings
    dan437 authored and danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    1ca59cc View commit details
    Browse the repository at this point in the history
  7. Capitalize Activity log (#13002)

    * Capitalize Activity log
    
    * Update app/_locales/en/messages.json
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    tmashuang and Gudahtt committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    a53d8dd View commit details
    Browse the repository at this point in the history
  8. Lint fix changelog

    danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    2771e3b View commit details
    Browse the repository at this point in the history
  9. Lint fix changelog

    tmashuang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    b66d80f View commit details
    Browse the repository at this point in the history
  10. Add what's new notification for transaction insights (#13000)

    * Add what's new notification for transaction insights
    
    * locales file lint fix
    danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    7c4e306 View commit details
    Browse the repository at this point in the history
  11. Fix tx-insight accreditation styling (#13009)

    * Fix tx-insight accreditation styling
    
    - Ensure "Etherscan" appears capitalized
    - Ensure messages are separated by newline
    - Handle case where server returns `fetchedVia` that frontend doesn't
      support
    
    * Revert "Fix tx-insight accreditation styling"
    
    This reverts commit f7121d2.
    
    * New Fix tx-insight accreditation styling
    
    Co-authored-by: Dan Miller <danjm.com@gmail.com>
    gnidan and danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    e7b11be View commit details
    Browse the repository at this point in the history
  12. Dispose the trezor connect iframe upon lock (#13018)

    * Dispose the trezor connect iframe upon lock
    
    * Use KEYRING_TYPES.TREZOR
    
    * Update eth-trezor-keyring version
    danjm committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    a34f88e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a021e98 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Support EIP-1559 on Trezor Model One (#13023)

    * Support EIP-1559 on Trezor Model One
    
    * Update unit tests
    
    * Fix unit test
    
    * Run yarn lavamoat:auto
    danjm committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    c73c2d8 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    danjm committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    5db5ad0 View commit details
    Browse the repository at this point in the history