Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v10.28.3 RC #18535

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Version v10.28.3 RC #18535

merged 4 commits into from
Apr 11, 2023

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

@metamaskbot
Copy link
Collaborator Author

Builds ready [2cc41c9]
Page Load Metrics (1550 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97156111136
domContentLoaded13801877153110550
load14002021155013565
domInteractive13801877153110450

@danjm @legobeat @Gudahtt
Ensure that all networkConfiguration object in networkController stat…
6a14f12 
…e have an id (#18513)

* Ensure that all networkConfiguration object in networkController state have an id

* Lint fix

* Update app/scripts/migrations/084.ts

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

* Add unit tests for error cases

* Simplify code

* Remove unnecessary any typing

* Fix network controller type checking

* Lint fix

* Improve typing

---------

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm
Copy link
Contributor

danjm commented Apr 11, 2023

My QA on this looked good

@metamaskbot
Copy link
Collaborator Author

Builds ready [0ef2680]
Page Load Metrics (1664 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101156121178
domContentLoaded14431908165614067
load14431908166414469
domInteractive14431908165614067

@danjm danjm marked this pull request as ready for review April 11, 2023 23:12
@danjm danjm requested a review from a team as a code owner April 11, 2023 23:12
@danjm danjm temporarily deployed to desktop April 11, 2023 23:12 — with GitHub Actions Inactive
@danjm
Copy link
Contributor

danjm commented Apr 11, 2023

okay, I tested a second time

first time was against the test dapp, second time against the optimism bridge dapp. Consistent failing on v10.28.2 and then working on this branch

also, Thomas QA'd the one PR included here earlier and it was good

I'm gonna merge

@danjm danjm merged commit 2fb016e into master Apr 11, 2023
@danjm danjm deleted the Version-v10.28.3 branch April 11, 2023 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@danjm danjm danjm approved these changes

@matthewwalsh0 matthewwalsh0 Awaiting requested review from matthewwalsh0 matthewwalsh0 is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metamaskbot @danjm @adonesky1 @legobeat