-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants with enums #19516
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/components/app/modals/contract-details-modal/contract-details-modal.js
Outdated
Show resolved
Hide resolved
ui/components/app/modals/contract-details-modal/contract-details-modal.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catches! Please update with your suggestions and I can approve. Well done 💯
ui/components/app/modals/contract-details-modal/contract-details-modal.js
Outdated
Show resolved
Hide resolved
ui/components/app/modals/contract-details-modal/contract-details-modal.js
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #19516 +/- ##
===========================================
- Coverage 70.17% 70.16% -0.01%
===========================================
Files 963 963
Lines 36980 36980
Branches 9510 9510
===========================================
- Hits 25948 25946 -2
- Misses 11032 11034 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @dhruvv173
Explanation
ui/components/app/advanced-gas-fee-popover/advanced-gas-fee-defaults/advanced-gas-fee-defaults.js
ui/components/app/modals/contract-details-modal/contract-details-modal.js
ui/components/app/network-account-balance-header/network-account-balance-header.js
Screenshots/Screencaps
Before
Theres no story for
advanced-gas-fee-defaults
contract-details-modal
network-account-balance-header
After
contract-details-modal
network-account-balance-header
Manual Testing Steps
yarn storybook
contract-details-modal
andnetwork-account-balance-header
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.