feat: add announcement for users that blockaid will be enabled by default #22338

jpuri · 2023-12-19T12:57:58Z

Description

Add announcement that blockaid is now enabled by default.

Related issues

Fixes: MetaMask/MetaMask-planning#1835

Manual testing steps

Reload the extension
Find announcement that blockaid not now available by default

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-12-19T12:58:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2023-12-19T15:25:09Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f76c353) 67.92% compared to head (94e45f1) 67.91%.
Report is 1 commits behind head on develop.

Files	Patch %	Lines
.../components/app/whats-new-popup/whats-new-popup.js	0.00%	2 Missing ⚠️
shared/notifications/index.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22338      +/-   ##
===========================================
- Coverage    67.92%   67.91%   -0.00%     
===========================================
  Files         1070     1070              
  Lines        41360    41364       +4     
  Branches     11113    11115       +2     
===========================================
+ Hits         28091    28092       +1     
- Misses       13269    13272       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-12-19T15:36:55Z

Builds ready [94e45f1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1294 ± 152 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	343	205	87	42
		domContentLoaded	9	209	90	80	38
		load	821	2037	1294	316	152
		domInteractive	9	209	90	80	38

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 61 Bytes (0.00%)
common: 880 Bytes (0.02%)

shared/notifications/index.js

segun · 2024-01-09T22:04:35Z

app/_locales/en/messages.json

@@ -2971,6 +2971,21 @@
  "notifications24Title": {
    "message": "Advanced gas fees by network"
  },
+  "notifications29ActionText": {
+    "message": "Got it"


we have a few of instances of this message already. can we re-use the 'gotIt' key for this instead of creating another one?

not sure if there is a PR open for this yet, but we'll want to update the gotIt translation key for all language files to something like 'gotItExclamation' and condense the instances mentioned to "gotIt"

segun

Changes look good, just a nit about locales.

HowardBraham · 2024-01-10T00:29:07Z

Can we please use the new format that would replace all those 29s with something like NOTIFICATION_BLOCKAID_DEFAULT?

This new format makes it a lot easier to deal with merge conflicts.

… blockaid_default_announcement

jpuri · 2024-01-10T15:01:54Z

NOTIFICATION_BLOCKAID_DEFAULT

Thanks @HowardBraham : I made code updates.

shared/notifications/index.js

digiwand · 2024-01-10T16:53:36Z

app/_locales/en/messages.json

@@ -2971,6 +2971,21 @@
  "notifications24Title": {
    "message": "Advanced gas fees by network"
  },
+  "notifications29ActionText": {
+    "message": "Got it"


not sure if there is a PR open for this yet, but we'll want to update the gotIt translation key for all language files to something like 'gotItExclamation' and condense the instances mentioned to "gotIt"

…etamask-extension into blockaid_default_announcement

HowardBraham · 2024-01-10T23:04:30Z

@jpuri Thanks for the replacement of the 29s, and that merge conflict already happened, pushing this to 30!

I noticed one more thing though. I think all these ///: BEGIN:ONLY_INCLUDE_IF(blockaid) only increase the complexity of the build. You could accomplish the same thing if you removed all of these code fences, then in selectors.js just had
[NOTIFICATION_BLOCKAID_DEFAULT]: whatever_checks_for_blockaid_at_runtime,

jpuri · 2024-01-11T10:20:26Z

@jpuri Thanks for the replacement of the 29s, and that merge conflict already happened, pushing this to 30!

I noticed one more thing though. I think all these ///: BEGIN:ONLY_INCLUDE_IF(blockaid) only increase the complexity of the build. You could accomplish the same thing if you removed all of these code fences, then in selectors.js just had [NOTIFICATION_BLOCKAID_DEFAULT]: whatever_checks_for_blockaid_at_runtime,

@HowardBraham : all of blockaid code is currently code fenced and I would prefer to keep it this way, also we do not have a corresponding runtime check for code fencing.

Add announcement for users that blockaid will be enabled by default

a6df89d

jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 19, 2023

jpuri requested a review from a team as a code owner December 19, 2023 12:57

fix

94e45f1

jpuri changed the title ~~Add announcement for users that blockaid will be enabled by default~~ feat: add announcement for users that blockaid will be enabled by default Jan 5, 2024

digiwand previously approved these changes Jan 9, 2024

View reviewed changes

segun reviewed Jan 9, 2024

View reviewed changes

shared/notifications/index.js Outdated Show resolved Hide resolved

segun reviewed Jan 9, 2024

View reviewed changes

jpuri added 2 commits January 10, 2024 19:23

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

caea3ac

… blockaid_default_announcement

Update

5246935

jpuri dismissed digiwand’s stale review via 5246935 January 10, 2024 15:01

jpuri requested review from segun and digiwand January 10, 2024 15:02

jpuri added 4 commits January 10, 2024 20:48

Update

da58fc3

Update

94bde80

merge

74370ed

Merge branch 'develop' into blockaid_default_announcement

aff8880

digiwand requested changes Jan 10, 2024

View reviewed changes

Update

762d8b2

jpuri requested a review from digiwand January 10, 2024 17:19

Merge branch 'blockaid_default_announcement' of github.com:MetaMask/m…

9b2c246

…etamask-extension into blockaid_default_announcement

digiwand previously approved these changes Jan 10, 2024

View reviewed changes

Merge branch 'develop' into blockaid_default_announcement

a4c605e

Merge branch 'develop' into blockaid_default_announcement

18b0e55

segun previously approved these changes Jan 10, 2024

View reviewed changes

jpuri added 4 commits January 10, 2024 23:22

Merge branch 'develop' into blockaid_default_announcement

7079fb6

Merge branch 'develop' into blockaid_default_announcement

363ff01

fix

a11601f

Merge branch 'blockaid_default_announcement' of github.com:MetaMask/m…

9cc54ae

…etamask-extension into blockaid_default_announcement

jpuri dismissed stale reviews from digiwand and segun via 9cc54ae January 10, 2024 18:11

jpuri requested review from segun and digiwand January 10, 2024 18:22

jpuri added 2 commits January 11, 2024 10:59

Update

63493cd

Update

c539de9

cryptotavares approved these changes Jan 11, 2024

View reviewed changes

segun approved these changes Jan 11, 2024

View reviewed changes

jpuri merged commit 19a9a5e into develop Jan 11, 2024
67 of 68 checks passed

jpuri deleted the blockaid_default_announcement branch January 11, 2024 14:33

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 11, 2024

github-actions bot locked and limited conversation to collaborators Jan 11, 2024

metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Jan 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add announcement for users that blockaid will be enabled by default #22338

feat: add announcement for users that blockaid will be enabled by default #22338

jpuri commented Dec 19, 2023

github-actions bot commented Dec 19, 2023

codecov bot commented Dec 19, 2023

metamaskbot commented Dec 19, 2023

segun Jan 9, 2024

jpuri Jan 10, 2024

digiwand Jan 10, 2024

segun left a comment

HowardBraham commented Jan 10, 2024

jpuri commented Jan 10, 2024

digiwand Jan 10, 2024

HowardBraham commented Jan 10, 2024

jpuri commented Jan 11, 2024

feat: add announcement for users that blockaid will be enabled by default #22338

feat: add announcement for users that blockaid will be enabled by default #22338

Conversation

jpuri commented Dec 19, 2023

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 19, 2023

codecov bot commented Dec 19, 2023

Codecov Report

metamaskbot commented Dec 19, 2023

segun Jan 9, 2024

Choose a reason for hiding this comment

jpuri Jan 10, 2024

Choose a reason for hiding this comment

digiwand Jan 10, 2024

Choose a reason for hiding this comment

segun left a comment

Choose a reason for hiding this comment

HowardBraham commented Jan 10, 2024

jpuri commented Jan 10, 2024

digiwand Jan 10, 2024

Choose a reason for hiding this comment

HowardBraham commented Jan 10, 2024

jpuri commented Jan 11, 2024