Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensys.net -> consensys.io #22412

Merged
merged 8 commits into from
Jan 5, 2024
Merged

Conversation

kevin-chassagne
Copy link
Contributor

@kevin-chassagne kevin-chassagne commented Jan 4, 2024

Description

Update consensys.net url to consensys.io

Related issues

https://github.com/Consensys/dx-team/issues/1703

Manual testing steps

n/a

Screenshots/Recordings

n/a

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@kevin-chassagne kevin-chassagne requested a review from a team as a code owner January 4, 2024 11:10
Copy link
Contributor

github-actions bot commented Jan 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 4, 2024
@kevin-chassagne kevin-chassagne added needs-content Needs content / copy support. and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 4, 2024
@kevin-chassagne
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 4, 2024
shared/lib/ui-utils.js Outdated Show resolved Hide resolved
Co-authored-by: Victor Thomas <10986371+vthomas13@users.noreply.github.com>
…tamask-extension into fix/1703-dx-team-.net-to-.io
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (075db48) 68.15% compared to head (f449f9a) 68.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22412   +/-   ##
========================================
  Coverage    68.15%   68.15%           
========================================
  Files         1081     1081           
  Lines        42295    42295           
  Branches     11302    11302           
========================================
  Hits         28826    28826           
  Misses       13469    13469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f449f9a]
Page Load Metrics (1737 ± 156 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1344752538641
domContentLoaded17227786431
load104124191737324156
domInteractive17227776431
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -26 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@Anouk1973

This comment was marked as spam.

@kevin-chassagne kevin-chassagne merged commit fc8d223 into develop Jan 5, 2024
67 checks passed
@kevin-chassagne kevin-chassagne deleted the fix/1703-dx-team-.net-to-.io branch January 5, 2024 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-content Needs content / copy support. release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants