fix: Codespaces corepack enable
#25161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
changed the title
codepack enablecorepack enable
HowardBraham
requested review from
plasmacorral,
a team and
kumavis
as code owners
legobeat
reviewed
Jun 10, 2024
Builds ready [62f6aee]
Page Load Metrics (132 ± 166 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25161 +/- ##
========================================
Coverage 65.38% 65.39%
========================================
Files 1382 1382
Lines 54767 54767
Branches 14368 14368
========================================
+ Hits 35809 35810 +1
+ Misses 18958 18957 -1 ☔ View full report in Codecov by Sentry. |
legobeat
previously approved these changes
Jun 10, 2024
Builds ready [b1f8776]
Page Load Metrics (60 ± 5 ms)
Bundle size diffs
|
HowardBraham
force-pushed
the
codespaces-corepack-enable
branch
2 times, most recently
from
765965f
to
6c1fc9b
Compare
legobeat
reviewed
Jun 12, 2024
Builds ready [6c1fc9b]
Page Load Metrics (45 ± 2 ms)
Bundle size diffs
|
plasmacorral
previously approved these changes
Jun 12, 2024
HowardBraham
force-pushed
the
codespaces-corepack-enable
branch
from
6c1fc9b
to
cfea130
Compare
Builds ready [cfea130]
Page Load Metrics (49 ± 16 ms)
Bundle size diffs
|
legobeat
approved these changes
Jul 9, 2024
DDDDDanica
approved these changes
Jul 30, 2024
HowardBraham
force-pushed
the
codespaces-corepack-enable
branch
from
cfea130
to
5cb1199
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses issues with GitHub Codespaces setup and Yarn version compatibility, focusing on improving the development environment configuration.
- Updated
.devcontainer/devcontainer.jsonto fix Git operations and enable Corepack for Yarn - Modified
.devcontainer/download-builds.tsto handle 'Not Found' errors from CircleCI API - Updated Yarn version to 4.2.2 in both
package.jsonanddevelopment/generate-attributions/package.json - Disabled
git.autofetchto prevent potential rebase conflicts in Codespaces
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [5cb1199]
Page Load Metrics (313 ± 275 ms)
Bundle size diffs
|
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR continues to address GitHub Codespaces setup issues and Yarn version compatibility, with minor changes to improve the development environment.
- Updated
.circleci/config.ymlto usecorepack enablefor Yarn setup in CI/CD pipeline - Added new TypeScript files in
development/webpack/for improved build process management - Removed deprecated
coverage-targets.jsfile, likely part of test coverage refactoring - Updated various localization files (
app/_locales/) to remove 'attemptingConnect' message strings
255 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
… rebase onto multiple branches"
HowardBraham
force-pushed
the
codespaces-corepack-enable
branch
from
5cb1199
to
143368f
Compare
|
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR continues to address GitHub Codespaces setup and Yarn version compatibility issues, focusing on improving the development environment and updating dependencies. Key changes include:
- Updated devcontainer configuration to improve Git operations and package management
- Modified download-builds.ts to handle 'Not Found' errors gracefully
- Updated Yarn version to 4.2.2 in relevant package.json files
- Added new migration script (120.4) to remove obsolete properties from various controllers
- Improved account naming logic for snap-suggested account names in create-named-snap-account.tsx
- Converted institutional selectors from JavaScript to TypeScript, enhancing type safety
37 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
danjm
approved these changes
Aug 15, 2024
metamaskbot
added
the
release-12.4.0
Builds ready [143368f]
Page Load Metrics (208 ± 215 ms)
Bundle size diffs
|
gauthierpetetin
added
release-12.3.0
HowardBraham
added
contributor experience
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
corepack enableyes | yarn --immutablebecause it asksCorepack is about to download... Do you want to continue? [Y/n]"yarn": "^4.0.2"to"yarn": "^4.2.2"yarn download-buildsgit.autofetch, as it was probably causing thefatal: Cannot rebase onto multiple branchesRelated issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist