Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for convert-token-to-nft-modal component #25561

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 27, 2024

Description

This pull request updates the screenshot for the story on the devin/story-kgJ branch of the MetaMask extension repository. The change ensures that the visual output of the story is accurately reflected and up to date.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the devin/story-kgJ branch.
  2. Run the story.
  3. Verify the screenshot reflects the correct output as shown in the PR.

Screenshots/Recordings

Before

After

ConvertTokenToNFTModal

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Devin Run

This Devin run was requested by Devin.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:39
@metamaskbot metamaskbot added the team-ai AI team (for the Devin AI bot) label Jul 23, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the interaction testing and dependencies

Copy link

sonarcloud bot commented Jul 30, 2024

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 30, 2024 00:20
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 30, 2024 00:20
@metamaskbot
Copy link
Collaborator

Builds ready [e050415]
Page Load Metrics (75 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint72137102168
domContentLoaded95932157
load4111375189
domInteractive95932157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (6eafd29) to head (e050415).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25561   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1409     1409           
  Lines        49856    49856           
  Branches     13779    13779           
========================================
  Hits         34887    34887           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettbear garrettbear merged commit ab2f3d7 into develop Jul 30, 2024
75 checks passed
@garrettbear garrettbear deleted the devin/story-kgJ branch July 30, 2024 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 30, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants