feat: Migration #122 set redesignedConfirmationsEnabled to true

[digiwand]

Description

This migration sets redesignedConfirmationsEnabled to true. Some users may have explicitly turned off the experimental setting, which this migration will reset to true. This is intentional as we also plan to remove the setting in an upcoming release.

I also added the redesigned confirmation prop to the Sentry state log. I had to decide whether to add it to support the setting in the tests, so I went with adding it.

This PR also partially fixes the Sign Typed Data flaky test when testing the verified result.

---

Getting the tests to pass were a bit tricky. It turns out the migrations run after the fixtures are set. The withPreferencesController fixture method is no help here.

One way we discussed to set the desired test state is to set the previous migration data to the state and setting the fixture migration version to the current version:

meta: { version: 122 }

This would require opening a live version, extracting the latest migration state, and adding the mock state to the tests.

Instead, we manually toggle the setting off for each test that requires the old signature pages.

Related issues

Fixes: #24614
following Cherry-pick PR → #26046

Manual testing steps

1. Turn off the Experimental > Improved signature redesign setting
2. Run newest version with migration
3. Observe setting has been turned on

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[digiwand]

duplication code only applies to migrations 🤔 unsure how we usually go about this. should sonarcloud include these files?

[metamaskbot]

Builds ready [dca23ea]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 11 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	146	101	19	9
		domContentLoaded	9	86	27	18	9
		load	44	131	75	23	11
		domInteractive	9	86	27	18	9

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[jpuri]

Hey @digiwand : changes look good, can you plz ensure that this does not makes contract interaction visible to users.

[pedronfigueiredo]

Gentle reminder to import the migration in app/scripts/migrations/index.js

[digiwand]

Thanks @pedronfigueiredo! 🙏🏼 updated

[digiwand]

hi @jpuri, lgtm! old contract interaction continues to show. I believe the contract interaction redesign is controlled by the ENV var ENABLE_CONFIRMATION_REDESIGN

[digiwand]

had to resolve a merge conflict. Rereviews please 🙏🏼 @matthewwalsh0 @pedronfigueiredo

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (721a38b) to head (cbe032a).

Files	Patch %	Lines
app/scripts/migrations/122.ts	86.67%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25769      +/-   ##
===========================================
+ Coverage    69.67%   69.68%   +0.01%     
===========================================
  Files         1402     1403       +1     
  Lines        49652    49667      +15     
  Branches     13720    13723       +3     
===========================================
+ Hits         34594    34607      +13     
- Misses       15058    15060       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [a8b9686]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (79 ± 11 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	171	112	24	11
		domContentLoaded	9	81	34	19	9
		load	44	126	79	23	11
		domInteractive	9	80	34	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.15 KiB (0.03%)
• ui: 70 Bytes (0.00%)
• common: 34 Bytes (0.00%)

[greptile-apps]

PR Summary

(updates since last review)

The pull request introduces migration #122 to enable redesigned confirmations for all users by setting redesignedConfirmationsEnabled to true.

• Helper Function Addition: Added tempToggleSettingRedesignedConfirmations in test/e2e/helpers.js to manually toggle the redesignedConfirmationsEnabled setting.
• Test Integrity: Ensures tests requiring the old signature pages can manually toggle the setting off, maintaining test integrity during the transition.
• Migration Script: Added app/scripts/migrations/122.ts to set redesignedConfirmationsEnabled to true.
• Test Updates: Added app/scripts/migrations/122.test.ts to verify migration logic.
• Migration Index: Updated app/scripts/migrations/index.js to include the new migration script.

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [b86b30b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (155 ± 181 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	304	112	50	24
		domContentLoaded	9	106	30	24	11
		load	41	1798	155	378	181
		domInteractive	9	106	30	24	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.15 KiB (0.03%)
• ui: 70 Bytes (0.00%)
• common: 34 Bytes (0.00%)

[digiwand]

this seemed to have fixed some "Sign Typed Data" flaky tests I ran into