Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Temporarily disable Playwright Swaps tests #26050

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jul 23, 2024

Description

Temporarily disabling the tests that were added here, because they need to be more stable. Once they are, we can enable them again.

Related issues

Fixes:

Manual testing steps

  1. test-e2e-swap-playwright - OPTIONAL step will not be run in a pull request.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested review from kumavis and a team as code owners July 23, 2024 15:11
@dan437 dan437 requested a review from Gudahtt July 23, 2024 15:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Temporarily disabled Playwright Swaps tests in the CI pipeline to address stability issues.

  • Modified .circleci/config.yml to disable the test-e2e-swap-playwright - OPTIONAL job.
  • Ensures test-e2e-swap-playwright step will not run until tests are stabilized.
  • No changes to the actual test files or logic, only CI configuration adjustments.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

sonarcloud bot commented Jul 23, 2024

@metamaskbot metamaskbot added the team-transactions Transactions team label Jul 23, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (a3c4333) to head (ac8dcb0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26050   +/-   ##
========================================
  Coverage    69.68%   69.68%           
========================================
  Files         1405     1405           
  Lines        49701    49701           
  Branches     13738    13738           
========================================
  Hits         34630    34630           
  Misses       15071    15071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt merged commit 82382cd into develop Jul 23, 2024
83 of 84 checks passed
@Gudahtt Gudahtt deleted the disable-playwright-swaps branch July 23, 2024 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ac8dcb0]
Page Load Metrics (342 ± 319 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691911043015
domContentLoaded107727199
load402079342665319
domInteractive107727199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-swaps team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants