Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: MMI move duck and selector to TS #26125

Merged
merged 23 commits into from
Aug 13, 2024
Merged

chore: MMI move duck and selector to TS #26125

merged 23 commits into from
Aug 13, 2024

Conversation

zone-live
Copy link
Contributor

Description

Moves our institutional duck and selector files to TS:

ui/ducks/institutional/institutional.ts
ui/selectors/institutional/selectors.ts

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Jul 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b14b4c6]
Page Load Metrics (568 ± 418 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6748713910550
domContentLoaded1095332311
load422588568870418
domInteractive1095332311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3c401d6]
Page Load Metrics (345 ± 305 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7152315712058
domContentLoaded10128302813
load412143345635305
domInteractive10128302813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive marked this pull request as ready for review August 2, 2024 12:23
@albertolive albertolive requested review from a team as code owners August 2, 2024 12:23
@metamaskbot
Copy link
Collaborator

Builds ready [8da2a87]
Page Load Metrics (443 ± 405 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint574081178742
domContentLoaded974232010
load383262443844405
domInteractive974232010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [f9a2a15]
Page Load Metrics (63 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6612092157
domContentLoaded95421157
load389763157
domInteractive95421157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@cad49eb). Learn more about missing BASE report.

Files Patch % Lines
ui/pages/institutional/custody/custody.tsx 85.71% 1 Missing ⚠️
ui/selectors/institutional/selectors.ts 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #26125   +/-   ##
==========================================
  Coverage           ?   70.12%           
==========================================
  Files              ?     1434           
  Lines              ?    50289           
  Branches           ?    13895           
==========================================
  Hits               ?    35263           
  Misses             ?    15026           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [9515c54]
Page Load Metrics (382 ± 312 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7512993168
domContentLoaded10311963
load421821382649312
domInteractive10311963
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 717376e into develop Aug 13, 2024
78 checks passed
@zone-live zone-live deleted the MMI-5314-move-duck-and-selector-to-ts branch August 13, 2024 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 13, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@shane-t shane-t shane-t approved these changes

Assignees
No one assigned
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-mmi PRs from the MMI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zone-live @metamaskbot @shane-t @DDDDDanica @gauthierpetetin @albertolive