feat(btc): use new snap account flow for Bitcoin accounts #26183

ccharly · 2024-07-29T11:34:18Z

Description

This removes the old flow of creating Bitcoin accounts in favor of the new generic Snap account creation flow (that includes account renaming).

This PR does require the Bitcoin Snap to emit the suggested names, otherwise name accounts will be named as follow: Snap Account N (where N is the number of created Snap accounts + 1).

Related issues

Relates to:

https://github.com/MetaMask/snap-bitcoin-wallet/pull/210

Fixes:

https://github.com/MetaMask/accounts-planning/issues/530

Manual testing steps

Note

Since we have updated the Bitcoin Snap version to 0.4.0, you no longer need to manually install the Snap, it's being prebundled with the right version that supports account name suggestion

Create a Bitcoin account (should be named "Bitcoin Account" by default)
Create a Bitcoin testnet account (should be named "Bitcoin Testnet Account" by default)

Screenshots/Recordings

Before

After

Screen.Recording.2024-07-29.at.11.59.25.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-29T11:34:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-31T11:00:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (2beba47) to head (2c25cd9).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26183      +/-   ##
===========================================
- Coverage    69.95%   69.95%   -0.00%     
===========================================
  Files         1411     1410       -1     
  Lines        49963    49956       -7     
  Branches     13800    13799       -1     
===========================================
- Hits         34948    34942       -6     
+ Misses       15015    15014       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-31T11:13:01Z

Builds ready [4860aa9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (333 ± 323 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	379	119	93	44
		domContentLoaded	9	86	24	22	10
		load	38	2227	333	673	323
		domInteractive	9	86	24	22	10

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -2.03 KiB (-0.03%)
common: -20 Bytes (-0.00%)

ui/pages/confirmations/confirmation/templates/create-named-snap-account.js

…unt confirmation template

metamaskbot · 2024-07-31T17:05:18Z

Builds ready [e5a7ec0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (407 ± 329 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	380	117	77	37
		domContentLoaded	8	84	28	22	10
		load	37	1979	407	686	329
		domInteractive	8	84	28	22	10

Bundle size diffs [🚀 Bundle size reduced!]

background: -14 Bytes (-0.00%)
ui: -2.03 KiB (-0.03%)
common: -20 Bytes (-0.00%)

k-g-j

Lgtm!

Manual testing

Create Bitcoin mainnet account
https://github.com/user-attachments/assets/52349099-7207-4855-89ad-779dd5d2b328

Create Bitcoin testnet account
https://github.com/user-attachments/assets/fbf71c59-4afc-4848-97c1-625e0fa767a6

…coin

sonarcloud · 2024-07-31T18:14:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-31T18:40:21Z

Builds ready [2c25cd9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (419 ± 341 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	406	142	89	43
		domContentLoaded	9	117	32	27	13
		load	44	2085	419	711	341
		domInteractive	9	117	32	27	13

Bundle size diffs [🚀 Bundle size reduced!]

background: -14 Bytes (-0.00%)
ui: -2.03 KiB (-0.03%)
common: -20 Bytes (-0.00%)

k-g-j · 2024-09-17T14:26:21Z

Behaves as epected on Chrome version 128.0.6613.138 ✅

Screen.Recording.2024-09-17.at.10.20.59.AM.mov

Behaves as expect on Firefox version 130.0 ✅

Screen.Recording.2024-09-17.at.10.24.22.AM.mov

ccharly requested a review from a team as a code owner July 29, 2024 11:34

ccharly requested a review from k-g-j July 29, 2024 11:34

ccharly self-assigned this Jul 29, 2024

ccharly added the team-accounts label Jul 29, 2024

ccharly force-pushed the feature/use-new-snap-account-flow-for-bitcoin branch from 37da73f to 653f678 Compare July 30, 2024 09:58

ccharly requested a review from a team as a code owner July 30, 2024 09:58

ccharly force-pushed the feature/use-new-snap-account-flow-for-bitcoin branch 2 times, most recently from 94a1c1c to e79f7a2 Compare July 30, 2024 14:01

feat(btc): use new snap account flow for Bitcoin accounts

4860aa9

ccharly force-pushed the feature/use-new-snap-account-flow-for-bitcoin branch from e79f7a2 to 4860aa9 Compare July 31, 2024 10:41

k-g-j reviewed Jul 31, 2024

View reviewed changes

ui/pages/confirmations/confirmation/templates/create-named-snap-account.js Show resolved Hide resolved

ccharly requested a review from a team as a code owner July 31, 2024 15:58

refactor(snap-keyring): no longer forward address to showNameSnapAcco…

e5a7ec0

…unt confirmation template

ccharly force-pushed the feature/use-new-snap-account-flow-for-bitcoin branch from fdce80c to e5a7ec0 Compare July 31, 2024 16:35

k-g-j approved these changes Jul 31, 2024

View reviewed changes

gantunesr approved these changes Jul 31, 2024

View reviewed changes

Merge branch 'develop' into feature/use-new-snap-account-flow-for-bit…

2c25cd9

…coin

OGPoyraz approved these changes Aug 1, 2024

View reviewed changes

ccharly merged commit ed28508 into develop Aug 1, 2024
75 checks passed

ccharly deleted the feature/use-new-snap-account-flow-for-bitcoin branch August 1, 2024 08:16

github-actions bot locked and limited conversation to collaborators Aug 1, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 1, 2024

gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(btc): use new snap account flow for Bitcoin accounts #26183

feat(btc): use new snap account flow for Bitcoin accounts #26183

ccharly commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Jul 29, 2024

codecov bot commented Jul 31, 2024 •

edited

Loading

metamaskbot commented Jul 31, 2024

metamaskbot commented Jul 31, 2024

k-g-j left a comment

sonarcloud bot commented Jul 31, 2024

metamaskbot commented Jul 31, 2024

k-g-j commented Sep 17, 2024

feat(btc): use new snap account flow for Bitcoin accounts #26183

feat(btc): use new snap account flow for Bitcoin accounts #26183

Conversation

ccharly commented Jul 29, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 29, 2024

codecov bot commented Jul 31, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 31, 2024

metamaskbot commented Jul 31, 2024

k-g-j left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 31, 2024

Quality Gate passed

metamaskbot commented Jul 31, 2024

k-g-j commented Sep 17, 2024

ccharly commented Jul 29, 2024 •

edited

Loading

codecov bot commented Jul 31, 2024 •

edited

Loading