Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add manual scenario for network polling scenario #26195

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Jul 29, 2024

Description

This PR introduces a new test scenario which relates to a release-blocker for v12.0.0. This scenario is to verify that once the MetaMask UI is closed, the extension stops all network requests, including etherscan, eth_call, eth_getBalance, eth_blockNumber, and eth_getBlockByNumber to Infura or any other RPC provider. This check is vital for reducing unnecessary network traffic and enhancing both privacy and efficiency within the extension's operation.

Open in GitHub Codespaces

Related issues

Fixes: #25964
Related release blocker: #25951

Manual testing steps

Follow testing steps in this manual scenario

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue requested a review from a team as a code owner July 29, 2024 16:51
@chloeYue chloeYue added the area-qa Relating to QA work (Quality Assurance) label Jul 29, 2024
@chloeYue chloeYue self-assigned this Jul 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue added team-extension-platform area-documentation Issues relating to documentation, in the codebase and off. labels Jul 29, 2024
@chloeYue chloeYue changed the title Add manual scenario for network polling scenario doc: Add manual scenario for network polling scenario Jul 29, 2024
@chloeYue chloeYue marked this pull request as draft July 29, 2024 16:52
@chloeYue chloeYue changed the title doc: Add manual scenario for network polling scenario docs: Add manual scenario for network polling scenario Jul 29, 2024
@chloeYue chloeYue changed the title docs: Add manual scenario for network polling scenario test: Add manual scenario for network polling scenario Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (63cf934) to head (0416963).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26195   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1411     1411           
  Lines        49946    49946           
  Branches     13805    13805           
========================================
  Hits         34942    34942           
  Misses       15004    15004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [88f152d]
Page Load Metrics (862 ± 562 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922471453416
domContentLoaded1474392010
load6231958621170562
domInteractive1474392010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue marked this pull request as ready for review July 30, 2024 10:22
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
seaona
seaona previously approved these changes Jul 30, 2024
Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion but non-blocking

@metamaskbot
Copy link
Collaborator

Builds ready [1969bcf]
Page Load Metrics (82 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722941185426
domContentLoaded11160383416
load39197824321
domInteractive11160383416
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue
Copy link
Contributor Author

LGTM, just a small suggestion but non-blocking

Nice catch, added in a754fb5, thanks !

@chloeYue chloeYue requested a review from DDDDDanica July 30, 2024 11:15
@metamaskbot
Copy link
Collaborator

Builds ready [a587a66]
Page Load Metrics (72 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671751042311
domContentLoaded108730199
load50150722211
domInteractive108730199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Jul 30, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [0416963]
Page Load Metrics (65 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69158982110
domContentLoaded96424157
load4010865199
domInteractive96424157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue merged commit aceea3b into develop Jul 30, 2024
75 checks passed
@chloeYue chloeYue deleted the add-polling-test-scenario branch July 30, 2024 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 30, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. area-qa Relating to QA work (Quality Assurance) release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add manual scenario to verify that network polling stops when UI is closed
5 participants