-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add manual scenario for network polling scenario #26195
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26195 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1411 1411
Lines 49946 49946
Branches 13805 13805
========================================
Hits 34942 34942
Misses 15004 15004 ☔ View full report in Codecov by Sentry. |
Builds ready [88f152d]
Page Load Metrics (862 ± 562 ms)
Bundle size diffs
|
test/manual-scenarios/security/stop-network-polling-scenario.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Danica Shen <zhaodanica@gmail.com>
test/manual-scenarios/security/stop-network-polling-scenario.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small suggestion but non-blocking
Builds ready [1969bcf]
Page Load Metrics (82 ± 21 ms)
Bundle size diffs
|
Nice catch, added in a754fb5, thanks ! |
Builds ready [a587a66]
Page Load Metrics (72 ± 11 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
Builds ready [0416963]
Page Load Metrics (65 ± 9 ms)
Bundle size diffs
|
Description
This PR introduces a new test scenario which relates to a release-blocker for v12.0.0. This scenario is to verify that once the MetaMask UI is closed, the extension stops all network requests, including
etherscan
,eth_call
,eth_getBalance
,eth_blockNumber
, andeth_getBlockByNumber
to Infura or any other RPC provider. This check is vital for reducing unnecessary network traffic and enhancing both privacy and efficiency within the extension's operation.Related issues
Fixes: #25964
Related release blocker: #25951
Manual testing steps
Follow testing steps in this manual scenario
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist