fix: Adding migration 125 to remove Deprecated TxController Key from state

[NiranjanaBinoy]

Description

We are deleting the depreciated Txcontroller key to optimize state management and reduce clutter.

Related issues

Fixes: #26067

Manual testing steps

Method 1:

1. Load a build older than 11.7.0 (I worked with 11.6.0)
2. Send a transaction
3. Update to a local build created from develop
4. Inspect the background state and confirm that TxController:{transactions:[]} is present in the background state. and the meta: {version: (less than 124)}.
5. Update to a local build created from this PR branch
6. Reload the app and inspect the background to confirm TxController is no longer present and the version is updated to 125.

Method 2:

1. Load the app from this PR branch
2. Run chrome.storage.local.get(({ data, meta }) => chrome.storage.local.set({ data: { ...data, TxController: {transactions:[]} }, meta: {...meta, version: 124} }, () => { window.location.reload() }))
3. Inspect the background state and confirm that TxController:{transactions:[]} is present in the background state. and the meta: {version: 124}.
4. Build the branch again
5. Reload the app and inspect the background to confirm TxController is no longer present and the version is updated to 125.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (3dec722) to head (35ff595).
Report is 10 commits behind head on develop.

Files	Patch %	Lines
app/scripts/migrations/125.ts	90.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26267      +/-   ##
===========================================
+ Coverage    69.97%   69.98%   +0.01%     
===========================================
  Files         1411     1410       -1     
  Lines        49995    49910      -85     
  Branches     13805    13784      -21     
===========================================
- Hits         34981    34926      -55     
+ Misses       15014    14984      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [537c916]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (414 ± 337 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	349	135	76	36
		domContentLoaded	9	66	31	19	9
		load	39	2538	414	701	337
		domInteractive	9	66	31	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 743 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [35ff595]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (224 ± 223 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	300	109	51	25
		domContentLoaded	9	101	29	25	12
		load	39	1754	224	465	223
		domInteractive	9	101	29	25	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 743 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

LGTM