fix: Do not break application if no token details are found using getTokenStandardAndDetails #26324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
digiwand
changed the title
7 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26324 +/- ##
========================================
Coverage 69.97% 69.97%
========================================
Files 1422 1422
Lines 49938 49937 -1
Branches 13861 13861
========================================
Hits 34943 34943
+ Misses 14995 14994 -1 ☔ View full report in Codecov by Sentry. |
jpuri
reviewed
Aug 2, 2024
| }); | ||
| }; | ||
|
|
||
| getDecimals(); |
There was a problem hiding this comment.
Since PR is refactoring this useeffect, it may be useful to use this hook I think to avoid race conditions:
https://github.com/MetaMask/metamask-extension/blob/develop/ui/hooks/useAsyncResult.ts
There was a problem hiding this comment.
conversation continued below #26324 (comment)
Builds ready [edf1542]
Page Load Metrics (524 ± 366 ms)
Bundle size diffs
|
matthewwalsh0
previously approved these changes
Aug 2, 2024
Builds ready [40e1cd1]
Page Load Metrics (371 ± 299 ms)
Bundle size diffs
|
matthewwalsh0
previously approved these changes
Aug 12, 2024
| @@ -11,6 +11,7 @@ import { getTokenStandardAndDetails } from '../../../../../store/actions'; | |||
|
|
|||
| import { Box } from '../../../../../components/component-library'; | |||
| import { BlockSize } from '../../../../../helpers/constants/design-system'; | |||
| import * as hookModule from '../../../../../hooks/useAsyncResult'; | |||
There was a problem hiding this comment.
Minor, but why the as import?
There was a problem hiding this comment.
Nice catch! Missed this when I was copying over the import from another test file. Updated d4e60ac
vinistevam
previously approved these changes
Aug 13, 2024
digiwand
dismissed stale reviews from vinistevam and matthewwalsh0
via
8a411d0
|
Thanks for the reviews! Made an update and reverted an unnecessary snapshot update. May I get re-approvals here please? @matthewwalsh0 @vinistevam @jpuri |
vinistevam
approved these changes
Aug 13, 2024
matthewwalsh0
approved these changes
Aug 14, 2024
|
Builds ready [2e94356]
Page Load Metrics (317 ± 306 ms)
Bundle size diffs
|
digiwand
deleted the
fix-permit-dataTree-should-not-break-with-no-decimals
branch
metamaskbot
added
the
release-12.4.0
gauthierpetetin
added
release-12.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon further observation and while work on test cases with varying mock data, I found code improvements and, I believe, fixes related to the Permit code.
Related issues
Related to: #25410
Related to: #26107
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist