Skip to content

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Sep 22, 2025

Description

Patches these changes into the bridge-status-controller: MetaMask/core#6674

The change adds a 5s delay after the approval submission to reduce bridge transaction failures on Base

Changelog

CHANGELOG entry: fix: delay for 5s after submitting Base approval for swap

Related issues

Fixes: #20193

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

N/A

After

No visual changes, but there should be a 5s delay between the approval tx's submission and the trade tx on Base

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested a review from a team as a code owner September 22, 2025 19:53
@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Sep 22, 2025
@micaelae micaelae changed the title fix: delay for 5s after submitting Base approval fix: delay for 5s after submitting Base approval cp-7.56.0 Sep 22, 2025
cursor[bot]

This comment was marked as outdated.

SteP-n-s
SteP-n-s previously approved these changes Sep 22, 2025
@micaelae micaelae enabled auto-merge September 22, 2025 20:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micaelae micaelae added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit c26469d Sep 23, 2025
53 checks passed
@micaelae micaelae deleted the swaps-perps-delay-after-base-approval branch September 23, 2025 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2025
@metamaskbot metamaskbot added release-7.57.0 Issue or pull request that will be included in release 7.57.0 release-7.56.0 Issue or pull request that will be included in release 7.56.0 and removed release-7.57.0 Issue or pull request that will be included in release 7.57.0 labels Sep 23, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.56.0 on PR. Adding release label release-7.56.0 on PR and removing other release labels(release-7.57.0), as PR was cherry-picked in branch 7.56.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-S team-swaps-and-bridge Swaps and Bridge team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bridge transaction failing on Base for Perps deposit
5 participants