-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add instructions regarding tool versions and env variables in Readme #8788
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Set defaults for .js.env.example (will get copied over to .js.env and remove unneeded instructions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8788 +/- ##
=======================================
Coverage 41.60% 41.61%
=======================================
Files 1269 1269
Lines 30859 30859
Branches 3082 3082
=======================================
+ Hits 12840 12842 +2
+ Misses 17243 17242 -1
+ Partials 776 775 -1 ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
Bitrise✅✅✅ Commit hash: ef51376 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise✅✅✅ Commit hash: 348639c Note
|
Description
The MetaMask Mobile Platform team has identified improvements to the read me as a way improving the developer experience and onboarding.
Related issues
Fixes: #8622 improves the effectiveness of the read me.
Manual testing steps
Screenshots/Recordings
Before:
8622-before.mov
After:
8622-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist