Make compatible with EIP 1193, EIP 1102, and EIP 2255 (i.e. LoginPerSite) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
danfinlay
approved these changes
Nov 14, 2019
rekmarks
changed the title
|
It looks like this needs to be rebased; there are conflicts. |
use yarn update ethereum.send and related methods for EIP 1102 and 1193 compatibility add metadata retrieval refactor utils; use eth-json-rpc-errors implement EIP 1193 events receive accountsChanged notification from background add _metamask.sendBatch, eslint 4.0.0
rekmarks
force-pushed
the
LoginPerSite
branch
from
feb2cca
to
8760cf5
Compare
|
@Gudahtt fixed! |
Gudahtt
reviewed
Nov 21, 2019
rekmarks
force-pushed
the
LoginPerSite
branch
from
ea0c434
to
8a9b2cb
Compare
Gudahtt
requested changes
Nov 21, 2019
Gudahtt
reviewed
Nov 21, 2019
Gudahtt
reviewed
Nov 21, 2019
Gudahtt
reviewed
Nov 22, 2019
|
@Gudahtt, just pushed stuff, mostly related to things I marked resolved. Only significant changes worth looking over ought to be the |
Gudahtt
reviewed
Nov 22, 2019
Gudahtt
approved these changes
Nov 22, 2019
Gudahtt
added a commit
that referenced
this pull request
Jul 4, 2020
The `data` event was emitted from v3.0.0 of the inpage provider whenever a `notification` event was received from MetaMask. This event was removed in #11 because it was thought it was only used internally. Apparently `web3` was relying upon it though. It has been restored exactly as it was in v3.0.0, except now a deprecation warning is shown in the console the first time a listener is added for this event.
Merged
rekmarks
pushed a commit
that referenced
this pull request
Jul 4, 2020
The `data` event was emitted from v3.0.0 of the inpage provider whenever a `notification` event was received from MetaMask. This event was removed in #11 because it was thought it was only used internally. Apparently `web3` was relying upon it though. It has been restored exactly as it was in v3.0.0, except now a deprecation warning is shown in the console the first time a listener is added for this event.
Gudahtt
added a commit
that referenced
this pull request
Jul 15, 2020
An alias has been added to restore the `publicCOnfigStore` property that was renamed in #11. A warning is printed to the console upon first use, explaining that the property is deprecated and will be removed in the future.
Gudahtt
added a commit
that referenced
this pull request
Jul 15, 2020
An alias has been added to restore the `publicConfigStore` property that was renamed in #11. A warning is printed to the console upon first use, explaining that the property is deprecated and will be removed in the future.
rekmarks
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the inpage provider compatible with EIP 1193, EIP 1102, and EIP 2255 (i.e., this branch of the extension). It also sets us up for the December 16 API changes (basically, delete everything marked with
TODO:deprecate:2019-12-16).Some noteworthy changes:
yarnethereum._metamaskproxy moved from extension to hereethereum.sendfully implemented per EIP 11934.0.0We probably shouldn't merge this and publish the package until the extension's
LoginPerSitePR is approved, but we definitely review it now.