Make JSON-RPC error data
property optional
#31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the
data
property ofJsonRpcError
wasn't properly inferred as optional, but rather asunknown
. This is due to an issue(?) in TypeScript, whereunknown | undefined
is inferred simply asunknown
, so Superstruct can't properly make the (type of the) field optional.It's fixed by adding a new helper type,
OptionalField
, which explicitly makes a property (or multiple properties) of a type optional.This does not affect actual runtime validation of the types.