fixed login redirect and disabled lang options in settings #261
Conversation
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ScanQRPage
participant Navigation
User->>ScanQRPage: Clicks "Close" in logged-in drawer
ScanQRPage->>Navigation: goto("/main")
Navigation-->>ScanQRPage: Navigates to main screen
ScanQRPage->>ScanQRPage: Restart scan
sequenceDiagram
participant User
participant LanguageSettings
participant Selector
User->>LanguageSettings: Opens language settings
LanguageSettings->>Selector: Render options (English enabled, others disabled)
User->>Selector: Attempts to select disabled option
Selector-->>User: No action (option disabled)
Estimated code review effort2 (~15 minutes) Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
infrastructure/eid-wallet/src/routes/(app)/settings/language/+page.svelte (1)
25-25: Effective implementation of language restrictions.The disable logic correctly implements the requirement to disable non-English language options. Consider a minor simplification for better readability:
- disable={lang.name === "English" ? false : true} + disable={lang.name !== "English"}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet.xcodeproj/project.pbxprojis excluded by!**/gen/**infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettingsis excluded by!**/gen/**infrastructure/eid-wallet/src-tauri/gen/apple/eid-wallet_iOS/Info.plistis excluded by!**/gen/**platforms/pictique/static/images/user 2.pngis excluded by!**/*.pngpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (4)
infrastructure/eid-wallet/src/lib/ui/Selector/Selector.svelte(4 hunks)infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte(2 hunks)infrastructure/eid-wallet/src/routes/(app)/settings/language/+page.svelte(1 hunks)platforms/pictique/src/lib/fragments/ActionMenu/ActionMenu.svelte(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
platforms/pictique/src/lib/fragments/ActionMenu/ActionMenu.svelte (2)
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/lib/ui/Button/Button.svelte:83-83
Timestamp: 2025-05-08T08:40:51.710Z
Learning: In Svelte 5, event handlers should use lowercase DOM-style attributes (e.g., onclick={handler}) rather than the Svelte 3/4 syntax with the on: prefix (e.g., on:click={handler}). The on: syntax is deprecated in Svelte 5 though still supported for backward compatibility.
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/lib/ui/Button/Button.svelte:83-83
Timestamp: 2025-05-08T08:40:51.710Z
Learning: In Svelte 5, event handlers can be written using the lowercase DOM-style attributes (e.g., onclick) rather than the Svelte 3/4 syntax with the on: prefix (e.g., on:click). Both syntaxes are supported, but onclick is the newer approach introduced in Svelte 5.
infrastructure/eid-wallet/src/routes/(app)/settings/language/+page.svelte (2)
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/stories/Button.svelte:0-0
Timestamp: 2025-05-08T09:02:43.311Z
Learning: The project uses Svelte 5, which uses the new "runes" API including $props() for handling component props instead of the export let syntax from Svelte 3/4.
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/stories/Button.svelte:0-0
Timestamp: 2025-05-08T09:02:43.311Z
Learning: The project uses Svelte 5, which introduces the new "runes" API including $props() for handling component props instead of the export let syntax from Svelte 3/4.
infrastructure/eid-wallet/src/lib/ui/Selector/Selector.svelte (2)
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/stories/Button.svelte:0-0
Timestamp: 2025-05-08T09:02:43.311Z
Learning: The project uses Svelte 5, which introduces the new "runes" API including $props() for handling component props instead of the export let syntax from Svelte 3/4.
Learnt from: pixel-punk-20
PR: #121
File: platforms/metagram/src/stories/Button.svelte:0-0
Timestamp: 2025-05-08T09:02:43.311Z
Learning: The project uses Svelte 5, which uses the new "runes" API including $props() for handling component props instead of the export let syntax from Svelte 3/4.
🔇 Additional comments (7)
platforms/pictique/src/lib/fragments/ActionMenu/ActionMenu.svelte (1)
56-58: LGTM! Minor syntax improvement.The added parentheses around the comma operator expression improve readability by making it explicit that this is a single expression containing multiple operations.
infrastructure/eid-wallet/src/lib/ui/Selector/Selector.svelte (3)
16-16: Good addition of disable property.The optional
disableprop provides the necessary flexibility to control component interactivity.
26-26: Proper prop destructuring.The default value of
falseensures backward compatibility for existing usage.
37-37: Effective disable implementation.The CSS classes correctly handle the disabled state:
opacity-50provides visual feedbackpointer-events-noneprevents interactionselect-noneprevents text selectioninfrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (2)
21-21: Proper import for navigation functionality.The
gotoimport is correctly added to support the login redirect fix.
221-221: Effective login redirect implementation.The
goto("/main")call properly redirects users to the main screen when closing the logged-in drawer, addressing the login redirect issue mentioned in the PR objectives.infrastructure/eid-wallet/src/routes/(app)/settings/language/+page.svelte (1)
11-11: Good default language selection.Setting "English" as the default selected language ensures a consistent initial state.
Description of change
fixed the login redirect and also disabled lang options in settings
Issue Number
closes #255
closes #260
Type of change
How the change has been tested
Locally
Change checklist
Summary by CodeRabbit
New Features
Bug Fixes
User Experience
Style