Skip to content

Conversation

coodos
Copy link
Contributor

@coodos coodos commented Aug 22, 2025

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features
    • Introduced private/blind voting end-to-end: wallet deep-link/QR flow, voter registration, commitment submission, and blind tallying with results display and “View My Vote.”
    • eVoting app now gates UI by visibility, adds signing flow, and supports updated user-vote retrieval.
    • Control Panel gains real-time Loki log streaming, dynamic platform registry, and enhanced monitoring animations for sync and awareness.
  • Documentation
    • Added BlindVote overview and quick start.
  • Tests
    • Added cryptography and end-to-end tally tests.
  • Chores
    • Environment example added, config/build updates, dependencies aligned; removed Grafana/Promtail services.

Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces a new BlindVote TypeScript package and integrates blind voting across the eVoting frontend and API. Adds Loki-based log streaming and a platform registry to the Control Panel. Updates the eID Wallet to handle blind-vote deep links and submission. Removes Grafana/Promtail and large portions of the Web3 Adapter. Adds DB entity/migration and routes for blind voting.

Changes

Cohort / File(s) Summary
BlindVote library
infrastructure/blindvote/* (README.md, package.json, tsconfig.json, src/index.ts, src/core/types.ts, src/core/voting-system.ts, src/crypto/pedersen.ts, src/examples/example.ts, test-crypto-expert.ts, test-tally.ts)
New TypeScript package implementing Pedersen commitments on Ristretto255, a high-level VotingSystem, types, crypto utils, examples, and tests. Exposes barrel exports.
Control Panel: logging, registry, UI
infrastructure/control-panel/.env.example, .../src/lib/services/loki.ts, .../src/lib/services/registry.ts, .../src/routes/+page.svelte, .../src/routes/api/events/+server.ts, .../src/routes/monitoring/+page.svelte, .../src/lib/fragments/Nodes/VaultNode.svelte
Adds Loki query/streaming service and platform Registry service; dynamic platform loading and error states; SSE stream now uses Loki with fallback to mock; monitoring flow updated for evault_sync and awareness; VaultNode gets platform-specific split layout and handle positioning.
Compose cleanup
control-panel.compose.yml
Removes promtail and grafana services; leaves loki.
eID Wallet: blind vote + build config
infrastructure/eid-wallet/package.json, .../src/routes/(app)/scan-qr/+page.svelte, .../svelte.config.js, .../vite.config.js, .../src/routes/(app)/sign/+page.svelte (deleted)
Adds blind voting flow (QR/deep link detection, vote generation, submission), dependency and alias for blindvote, Node polyfills, env defines, and removes separate sign page.
eVoting frontend
platforms/eVoting/src/app/(app)/[id]/page.tsx, .../(app)/create/page.tsx, .../components/blind-voting-interface.tsx, .../components/voting-interface.tsx, .../app/api/blind-vote/session/route.ts, .../app/api/votes/blind/route.ts, .../lib/pollApi.ts
Adds blind voting UI and deep link/QR initiation, switches to private-poll blind interface, fetches blind tallies, updates vote submission, introduces API routes to forward blind-vote requests, and changes getUserVote(pollId, userId).
eVoting API backend
platforms/evoting-api/package.json, .../src/controllers/VoteController.ts, .../src/services/VoteService.ts, .../src/services/SigningService.ts, .../src/services/DeadlineCheckService.ts, .../src/database/data-source.ts, .../src/database/entities/PollVotingState.ts, .../src/database/entities/Vote.ts, .../src/database/migrations/1755778782085-migration.ts, .../src/index.ts, .../src/web3adapter/watchers/subscriber.ts
Adds blind voting endpoints and logic (register, submit, generate, tally), per-poll VotingSystem cache, new entity/migration for poll voting state, extends Vote types with blind mode, updates routes (public), signing flow to branch by visibility, deadline results handling to use blind tallies with fallback, and removes a subscriber hook.
Web3 Adapter removals and logging changes
infrastructure/web3-adapter/src/db/* (deleted), .../src/evault/* (deleted), .../src/logging/* (deleted), .../src/mapper/* (deleted), .../src/index.d.ts (deleted), .../src/index.js (deleted), .../src/index.ts
Removes EVault client, mapping DB, mapper, and logging transport/aggregator; retains index.ts with adjusted logging and return payload tweaks.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant FE as eVoting Frontend
  participant Wallet as eID Wallet
  participant API as eVoting API
  participant BV as BlindVote Lib (API)
  participant DB as DB

  rect rgb(235,245,255)
  note right of FE: Private poll
  User->>FE: Open poll
  FE->>FE: Generate w3ds:// blind-vote deep link
  FE-->>User: Show QR / Open Wallet
  end

  rect rgb(245,255,245)
  User->>Wallet: Scan QR / Open deep link
  Wallet->>API: Check/register voter (POST /api/votes/:pollId/register)
  API->>DB: Upsert voting state
  API-->>Wallet: OK
  Wallet->>BV: Generate commitments/anchors (local)
  Wallet->>API: Submit blind vote (POST /api/votes/:pollId/blind)
  API->>DB: Store commitments/anchors
  API-->>Wallet: Success
  Wallet-->>User: Confirm submission
  end

  rect rgb(255,245,235)
  note over API,BV: Tally (on demand / deadline)
  FE->>API: GET /api/polls/:pollId/blind-tally
  API->>DB: Load blind votes
  API->>BV: Rebuild VotingSystem, tally
  BV-->>API: Counts + (C_agg, H_S, X)
  API-->>FE: Blind results
  FE-->>User: Display tallies
  end
Loading
sequenceDiagram
  autonumber
  participant CP as Control Panel (SSE)
  participant Loki as Loki
  participant WA as Web3 Adapter

  rect rgb(240,240,255)
  CP->>Loki: streamLogs({app="web3-adapter"})
  Loki-->>CP: log lines (polling)
  CP->>CP: parse -> FlowEvent
  CP-->>Client: SSE evault_sync_event
  end
Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

  • prototype#115 — Operates on the same Web3 Adapter modules; this PR removes those APIs while feat: web3 adapter #115 adds/defines them.
  • prototype#302 — Modifies the same eID Wallet scan-qr flow; overlaps with blind-vote handling introduced here.
  • prototype#273 — Touches eVoting backend models/routes; aligns with this PR’s API/entity changes.

Suggested reviewers

  • sosweetham
  • JulienAuvo

Poem

A rabbit taps the ledger’s rhyme,
Commitments hop in secret time.
Anchors blink—no names revealed—
Tallies bloom, yet votes are sealed.
Loki whispers, streams alight,
Private carrots counted right.
Thump-thump—privacy in sight! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/evoting-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coodos coodos merged commit 7b9150c into main Aug 22, 2025
0 of 4 checks passed
@coodos coodos deleted the feat/evoting-fixes branch August 22, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant