chore: eVoting fixes

[coodos]

Description of change

Issue Number

Type of change

• Breaking (any change that would cause existing functionality to not work as expected)
• New (a change which implements a new feature)
• Update (a change which updates existing functionality)
• Fix (a change which fixes an issue)
• Docs (changes to the documentation)
• Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features

  • Private polls with blind voting and a “Your Private Vote” modal.
  • All Polls page revamped into a searchable, sortable, paginated table.

• Improvements

  • Ended polls now show final results with winner badges, percentages, and progress bars.
  • Clearer post-vote messaging: distinct states for private (blind) and public votes.

• Changes

  • Create Poll: deadline is now required; added Vote Visibility selector; ranked/points disabled for private polls.
  • Sign/QR flow: removed “Your Vote” preview from the signing drawer.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Frontend and backend for eVoting were updated to add paginated/searchable/sortable polls listing, refine poll detail flows (private blind voting, end-of-poll results), adjust create-poll validation and visibility controls, enhance voted-state UI, modify points-mode storage/tallying, and remove a wallet “Your Vote” display block. APIs and services now support new list parameters and results structures.

Changes

Cohort / File(s)	Summary
Wallet Sign UI infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte	Removed “Your Vote” display block from signing drawer; retained poll details and signing flow. No logic changes.
Poll Detail Page platforms/eVoting/src/app/(app)/[id]/page.tsx	Reworked end-of-poll results rendering for public/private; added blind tally fetch/refresh flow; added “Your Private Vote” modal; updated active-poll UI and submission confirmations; preserved signing flow.
Create Poll Page platforms/eVoting/src/app/(app)/create/page.tsx	Made deadline required with updated validation/UI; introduced Vote Visibility (Public/Private); disabled points/rank when Private; removed duplicate visibility block; coupled mode with visibility.
All Polls Listing platforms/eVoting/src/app/(app)/page.tsx	Replaced cards with a paginated/searchable/sortable table; integrated debounced search, clickable sort headers, and pagination controls; uses new PollsResponse shape.
Voting Interface Component platforms/eVoting/src/components/voting-interface.tsx	Expanded hasVoted UI: distinct private “Blind Vote Submitted” state and public “Vote Submitted” with disabled options list; added Shield icon.
Frontend Poll API platforms/eVoting/src/lib/pollApi.ts	Added PollsResponse type; extended getAllPolls(page, limit, search, sortField, sortDirection) to return paginated data; getUserVote now returns { hasVoted, vote }.
Backend Controller platforms/evoting-api/src/controllers/PollController.ts	getAllPolls now accepts page/limit/search/sort params with validation; forwards to service; returns paginated result.
Backend Poll Service platforms/evoting-api/src/services/PollService.ts	getAllPolls expanded: search filter, findAndCount, in-memory multi-criteria sorting (status/title/mode/visibility/votes/deadline), pagination, structured response.
Backend Vote Service platforms/evoting-api/src/services/VoteService.ts	Adjusted points-mode storage handling; implemented points-mode results aggregation; added unknown-mode error in results; removed debug logs from blind tally.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant FE as Frontend (Polls Page)
  participant API as evoting-api (Controller)
  participant SVC as PollService
  participant DB as Database

  User->>FE: Open All Polls / interact (search/sort/page)
  FE->>API: GET /api/polls?page&limit&search&sortField&sortDirection
  API->>SVC: getAllPolls(params)
  SVC->>DB: findAndCount(where: search)
  DB-->>SVC: polls[], total
  SVC->>SVC: sort (status/title/mode/visibility/votes/deadline)
  SVC->>SVC: paginate (slice by page/limit)
  SVC-->>API: { polls, total, page, limit, totalPages }
  API-->>FE: JSON response
  FE-->>User: Render table, pager, sort indicators

Loading

sequenceDiagram
  autonumber
  actor Voter
  participant FE as Frontend (Poll Detail)
  participant SI as Signing Interface
  participant API as evoting-api
  participant VS as VoteService

  Voter->>FE: Select options and submit
  FE->>SI: Open signing drawer (no vote preview in wallet)
  SI-->>FE: Signature success
  FE->>API: POST vote (public or private)
  API->>VS: createVote(data)
  VS-->>API: stored vote
  API-->>FE: 200 OK
  alt Private poll
    FE->>API: GET /blind-tallies (on submit/refresh)
    API->>VS: tallyBlindVotes()
    VS-->>API: blindVoteResults
    API-->>FE: results
    FE-->>Voter: Show "Blind Vote Submitted" and hide live results until end
  else Public poll
    FE-->>Voter: Show "Vote Submitted" and disabled options
  end
  opt After deadline
    FE->>API: GET final results
    API->>VS: getPollResults()
    VS-->>API: results (normal/rank/point)
    API-->>FE: results
    FE-->>Voter: Render final results with winner/percentages
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60–90 minutes

Possibly related PRs

• Feat/evoting #273 — Prior eVoting changes across frontend and backend modules overlapping with poll listing and services.
• Feat/w3ds evoting #290 — Touches eVoting/eID wallet signing flows and pollApi endpoints similar to this PR’s signing and list API changes.
• Chore/final fixes ms3 #302 — Modifies the same wallet scan-qr signing UI, related to the removed “Your Vote” display.

Suggested reviewers

• sosweetham

Poem

I tapped my paw on ballots bright,
Hid votes in shadows, out of sight. 🛡️
Tables turned with tidy rows,
Pages, sorts, and search that flows.
When deadlines chime, the winners gleam—
A rabbit nods: “Democracy, supreme!” 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0420efc and f002d58.

📒 Files selected for processing (9)

• infrastructure/eid-wallet/src/routes/(app)/scan-qr/+page.svelte (0 hunks)
• platforms/eVoting/src/app/(app)/[id]/page.tsx (2 hunks)
• platforms/eVoting/src/app/(app)/create/page.tsx (5 hunks)
• platforms/eVoting/src/app/(app)/page.tsx (2 hunks)
• platforms/eVoting/src/components/voting-interface.tsx (2 hunks)
• platforms/eVoting/src/lib/pollApi.ts (2 hunks)
• platforms/evoting-api/src/controllers/PollController.ts (1 hunks)
• platforms/evoting-api/src/services/PollService.ts (1 hunks)
• platforms/evoting-api/src/services/VoteService.ts (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/final-evoting-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.