Switch from using bash scripts to python scripts for creating resources #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofay
approved these changes
Jun 17, 2024
maxdymond
force-pushed
the
md/resourcescript
branch
from
d030018 to
fc62583
Compare
maxdymond
force-pushed
the
md/resourcescript
branch
from
fc62583 to
4de224a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes related to improving code quality, updating documentation, and modifying the build process. The most significant changes include updating the Python version requirement, removing shell scripts in favor of Python scripts, and modifying the linting and static analysis tools used in the project.
Changes to Python code and build process:
.flake8: Added rules to exclude certain directories and files from flake8 checking and added rules for flake8 to ignore certain warnings and errors..github/workflows/ci.yml: Removed the step for running pylint and added a step for running flake8.pyproject.toml: Updated the Python version requirement to 3.8.2, removed pylint from dev dependencies, and added flake8 and its plugins. Also added a script for creating resources in Azure.function_app.py: Removed an unnecessary import statement.create_resources.shandcreate_resources_nosharedkey.sh: Both shell scripts were removed. [1] [2]src/apt_package_function/__init__.py,src/apt_package_function/azcmd.py, andsrc/apt_package_function/bicep_deployment.py: Added new Python scripts to replace the functionality of the removed shell scripts. [1] [2] [3]Changes to documentation:
README.md: Updated the documentation to reflect the changes in the build process and the usage of the project. Also improved the explanation of the speed of repository updates. [1] [2] [3]Changes to Bicep deployment:
rg.bicep: Modified the output of the function app name.