Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #587

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

MikeAdamsMews
Copy link
Contributor

Changed Style Guide link to point to new location in Confluence

Summary

  • Updated link to Style Guide from Guru -> Confluence

Follow style guide

Style guide

Check during review

  • The changelog and potentially a deprecation entries are in place.
    • The changelog timestamp is date of merge to develop.
  • JSON example extended.
    • New properties are added to the correct place in the JSON.
  • New properties in the table are added to the correct place.
  • Correct formatting:
    • Spacing is consistent between titles, sections, tables, ...
    • Correct JSON format - indentation.
  • DateTime properties should always be defined in ISO format.

Changed Style Guide link to point to new location in Confluence
@MikeAdamsMews MikeAdamsMews requested a review from vitezp May 17, 2024 15:50
Copy link
Member

@jnv jnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is invalid.

Anyway, since this repository is public, have you considered mirroring the contents of the document in CONTRIBUTING.md file and link it from Confluence?

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Vlnas <jan.vlnas@mews.com>
@MikeAdamsMews
Copy link
Contributor Author

The link is invalid.

Anyway, since this repository is public, have you considered mirroring the contents of the document in CONTRIBUTING.md file and link it from Confluence?

Of course you're right @jnv, I should do that, but that will be a separate task.

@MikeAdamsMews MikeAdamsMews merged commit 190626c into master Jul 30, 2024
3 checks passed
@MikeAdamsMews MikeAdamsMews deleted the MikeAdamsMews-patch-1 branch July 30, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants