Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "more readable exception handling _connect_tcp()" #2

Merged
merged 1 commit into from
Mar 20, 2012
Merged

Revert "more readable exception handling _connect_tcp()" #2

merged 1 commit into from
Mar 20, 2012

Commits on Mar 20, 2012

  1. Revert "more readable exception handling _connect_tcp()" 

    This reverts commit da8cb1a.

It turned out that da8cb1 actually changed the API of python-mpd: if an error
occurred while connecting to the MPD server, MPDClient._connect_tcp() would always
return 'ConnectionError("getaddrinfo returns an empty list"), even if getaddrinfo()
actually returned something.

I have no idea how to make getaddrinfo() returns nothing, so it's hard to test at
the moment.

Conflicts:

	test.py
    @multani
    multani committed Mar 20, 2012
    Configuration menu
    Copy the full SHA
    c1369ca View commit details
    Browse the repository at this point in the history