Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dietpi-{software,services}: Added soju IRC bouncer #7124

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

subnut
Copy link
Contributor

@subnut subnut commented Jun 23, 2024

The corresponding pull request in MichaIng/DietPi-Docs shall be made soon.

@subnut
Copy link
Contributor Author

subnut commented Jun 23, 2024

The shellcheck failure is spurious.

GOFLAGS=... is an argument to the make call, not a bash variable.

dietpi/dietpi-software Outdated Show resolved Hide resolved
dietpi/dietpi-software Outdated Show resolved Hide resolved
@MichaIng
Copy link
Owner

MichaIng commented Jun 25, 2024

First of all, many thanks for your contribution!
Linking the docs PR: MichaIng/DietPi-Docs#1013

From Debian Trixie on, there will be a native Debian package: https://packages.debian.org/soju
However, as always, the version is frozen in stable Debian releases. So depending on Soju release schedule, and how significant features or new releases are, we may want to stick with latest version compiled from source.

In general, it would be also possible for us to create own DEB packages, like we do for some other software titles, distributed via our own APT repository.

dietpi/dietpi-software Outdated Show resolved Hide resolved
- DietPi-Software | soju: Get latest version for GitHub API automatically. Fix syntax to pass GOFLAGS correctly. Make /mnt/dietpi_userdata/soju the home dir for the soju user. Slight systemd unit cleanup. Align uninstall code.
- CI | DietPi-Software: Add test service and TCP port for soju
- META | Add changelog and readme entry about soju, and support it with our survey report page.
@MichaIng
Copy link
Owner

MichaIng commented Jul 2, 2024

Syntax fixed, download switched to GitHub API, tests implemented and running: https://github.com/MichaIng/DietPi/actions/runs/9768008300

One more question as code comment:

dietpi/dietpi-software Outdated Show resolved Hide resolved
dietpi/dietpi-software Outdated Show resolved Hide resolved
- DietPi-Software | soju: Remove possible endless restart loop on failure. If a service crashes, it should be recognised by admins and checked for the reason. A restart usually fails just the same way, resulting in an endless loop, spamming logs and worsen mans possible causes: I/O errors, filesystem corruption, RAM usage, disk usage, etc.
- CI | DietPi-Software: Set HOME path for tests in emulated Trixie systems, where tests are started from a systemd service. HOME is not set by default in this case, which causes e.g. Go and Rust builds to fail.
- DietPi-Software | soju: Assure service is enabled on install, try without pkg-config and remove unneeded RuntimeDirectoryMode and RuntimeDirectoryPreserve
@MichaIng MichaIng merged commit 1470a6b into MichaIng:dev Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants