-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Curl] Upgrades 2019.05.08 #6429
[Curl] Upgrades 2019.05.08 #6429
Conversation
@ras0219-msft: A heads-up: CURL 7.64.1 breaks the This is fixed in the next version of CURL, which is scheduled for release 22nd of May 2019. (Note: This will require renaming the |
CURL 7.65 is now available. Per the above, the |
Thanks a bunch for the heads-up, @past-due! |
…L since we don't build the manual anyway.
ping @ras0219-msft Something holding this PR from merging? |
No, LGTM. Thanks for the great work @PhoebeHui and the review @past-due! |
Related PR #6382
The new upgrade in Curl, it moved deprecated #define CURLE_SSL_CACERT CURLE_PEER_FAILED_VERIFICATION to ifndef block in commit 0fd4427f, we didn’t define CURL_NO_OLDIES, so the following code enabled:
#define CURLE_SSL_CACERT CURLE_PEER_FAILED_VERIFICATION
In cpr\error.cpp reference 2 cases that both have same case value, so it failed with ‘error C2196: case value '60' already used’.
case CURLE_PEER_FAILED_VERIFICATION:
return ErrorCode::SSL_REMOTE_CERTIFICATE_ERROR;
case CURLE_SSL_CACERT:
return ErrorCode::SSL_CACERT_ERROR;
So I removed one of them to fix it.