Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The comment in locale.json does not change from Chinese to English after changing locale from "zh-cn" to "en" #46179

Closed
shizengzhou opened this issue Mar 20, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations)

Comments

@shizengzhou
Copy link
Contributor

Issue Type: Bug

  1. Configure language, change locale from "zh-cn" to "en"
  2. Restart vscode
    locale

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 6.3.9600

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4210H CPU @ 2.90GHz (4 x 2893)
Memory (System) 7.89GB (1.59GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions: none Reproduces without extensions
@vscodebot
Copy link

vscodebot bot commented Mar 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

shizengzhou added a commit to shizengzhou/vscode that referenced this issue Mar 20, 2018
@vscodebot vscodebot bot removed the new release label Mar 20, 2018
@dbaeumer dbaeumer added l10n-platform Localization platform issues (not wrong translations) bug Issue identified by VS Code Team member as probable bug labels Mar 21, 2018
@dbaeumer
Copy link
Member

@shizengzhou any reason why you closed the issue and the PR

@shizengzhou
Copy link
Contributor Author

@dbaeumer In the latest VS Code Insiders, I find there is no comment in locale.json, so I think the issue and the PR are no longer needed.
locale

@dbaeumer
Copy link
Member

@shizengzhou could it be that you deleted the comments. We still generate it when we create the file for the first time. See here:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/localizations/electron-browser/localizationsActions.ts#L23

@shizengzhou
Copy link
Contributor Author

@dbaeumer Yeah, I saw the code. My latest VS Code Insiders is a new installation, I didn't delete the comments. I will reopen the issue and the PR.

@shizengzhou shizengzhou reopened this Apr 25, 2018
@blackmarkCH
Copy link

blackmarkCH commented Sep 10, 2018

has your issue been solved? now,I can't change "en" to "zh-cn".
=.=b
My ver is 1.27.1.

@bpasero
Copy link
Member

bpasero commented Oct 9, 2019

We no longer surface this file to the user, closing.

@bpasero bpasero closed this as completed Oct 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations)
Projects
None yet
Development

No branches or pull requests

4 participants