Skip to content

Conversation

sdwheeler
Copy link
Collaborator

@sdwheeler sdwheeler commented Oct 28, 2024

PR Summary

Continuation of PR11493 - copy changes to other versions

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@sdwheeler
Copy link
Collaborator Author

@ArieHein FYI

Copy link
Contributor

Learn Build status updates of commit add499e:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Arrays.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_For.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Management/Suspend-Service.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Out-File.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Update-TypeData.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.WSMan.Management/Disconnect-WSMan.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Arrays.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_For.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Functions_Argument_Completion.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Numeric_Literals.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Pwsh.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Management/Split-Path.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Management/Suspend-Service.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Utility/Invoke-RestMethod.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Utility/Out-File.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Utility/Update-TypeData.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.WSMan.Management/Disconnect-WSMan.md ✅Succeeded View (powershell-7.2)
reference/7.4/Microsoft.PowerShell.Core/About/about_Arrays.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_For.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Functions_Argument_Completion.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Numeric_Literals.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Pwsh.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded View (powershell-7.4)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@michaeltlombardi michaeltlombardi merged commit 08748a9 into MicrosoftDocs:main Oct 28, 2024
6 checks passed
@ArieHein
Copy link
Contributor

@ArieHein FYI

Thanks for the heads up. Was planning to do one folder at a time, to also reduce the amount of review you guys and gals are doing :)

@sdwheeler
Copy link
Collaborator Author

No worries. Small changes like that can be done in bulk. We use Beyond Compare to copy changes across the versions. So updating the other versions is quick and easy.

@ArieHein
Copy link
Contributor

ArieHein commented Nov 5, 2024

@sdwheeler I have more fixes but this time to Markdown rules. Problem is one of your rules in the mardownlint is MD012 that requires empty lines after headers. Just in the 5.1 sub folder, there are over 400 files that have that issue, as you can see:
So you want a PR with so many fixes (it fixes more MD rules that are not complying with the markdownlint rules) ?

image

@sdwheeler
Copy link
Collaborator Author

sdwheeler commented Nov 5, 2024

@ArieHein There is one exception to MD022. We don't put a blank line after ## SYNOPSIS due to a bug in the publishing tool chain. We are working to fix that bug, but we are still months away before we can release it.

If there are occurrences in other places besides ## SYNOPSIS, then those can be fixed. With the one exception, these are the rules we want to enforce:

id    aliases                  description
--    -------                  -----------
MD012 {no-multiple-blanks}     Multiple consecutive blank lines
MD022 {blanks-around-headings} Headings should be surrounded by blank lines
MD031 {blanks-around-fences}   Fenced code blocks should be surrounded by blank lines
MD032 {blanks-around-lists}    Lists should be surrounded by blank lines
MD058 {blanks-around-tables}   Tables should be surrounded by blank lines

If you want to submit bulk updates, limit them to one folder per PR. And limit the change to fixing the blank lines. That will be easy to review.

@ArieHein
Copy link
Contributor

ArieHein commented Nov 5, 2024

That makes sense, this will probably decrease the number dramatically.

thanks for the headsup.

ill do it for the 7.4 and 7.5 as well as ive seen the issue to remove 7.2 folders

@sdwheeler sdwheeler deleted the sdw-w334889-i11493 branch November 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants