Skip to content

Conversation

ArieHein
Copy link
Contributor

@ArieHein ArieHein commented Feb 10, 2025

PR Summary

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

This comment was marked as outdated.

@ArieHein ArieHein changed the title Wave 16 Markdown and PS Styles Feb 10, 2025
Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

@ArieHein
Copy link
Contributor Author

hmm...something is broken in the workflow ?

Copy link
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the code block back to a code span in the example.

Copy link
Contributor

Learn Build status updates of commit 15d4c4e:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Utility/Export-Alias.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Export-Clixml.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Export-FormatData.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Export-PSSession.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Format-Custom.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Format-Hex.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Format-List.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Format-Table.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Format-Wide.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-Alias.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-Culture.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-Date.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-Error.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-EventSubscriber.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-FileHash.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-FormatData.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-Host.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-PSBreakpoint.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Utility/Get-PSCallStack.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

@sdwheeler sdwheeler merged commit 273bcc5 into MicrosoftDocs:main Feb 11, 2025
5 of 8 checks passed
@ArieHein ArieHein deleted the wave-16 branch February 11, 2025 18:53
@ArieHein
Copy link
Contributor Author

@sdwheeler
In general, would you prefer some paragraph text after the last code block to use full code block instead of inline ?

@sdwheeler
Copy link
Collaborator

In general, would you prefer some paragraph text after the last code block to use full code block instead of inline?

To be honest, the last sentence with the inline code should probably be made into a separate example or removed since it really isn't important to the example.

@ArieHein
Copy link
Contributor Author

ok ill try to make full code examples over inline and add some description after the code block.
Removing is more a content decision and ill leave that to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants