-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improve and modernize workaround for OpenSSH bug in SSH-Remoting-in-PowerShell.md #12108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and modernize workaround for OpenSSH bug in SSH-Remoting-in-PowerShell.md #12108
Conversation
@microsoft-github-policy-service agree |
This comment was marked as outdated.
This comment was marked as outdated.
ExpectationsThanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it. To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details. The docs team begins to review your PR if you request them to or if your PR meets these conditions:
You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge. While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST). |
It's perhaps a bit wordy, but I figured I'd put all my thoughts down in the interest of completeness. 🤷♂️ It can be pared down if desired. IMO, just nixing the 8.3 method altogether is probably ideal, but it's there and enhanced if it is preferred that it remain. |
Added an option that creates a symbolic link, for systems without 8.3 support and simplified the method to get the 8.3 name as a fallback.
a859ce5
to
a9aa51f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit 1e238e0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PubkeyAuthentication yes | ||
``` | ||
```powershell | ||
Get-CimInstance Win32_Directory -Filter 'Name="C:\\Program Files"' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking on replacing this command, specifically, was that the proposed command works no matter where it is installed, including non-standard paths. This only covers the case of it being installed in C:\Program Files
, specifically. 🤷♂️
Added an option that creates a symbolic link, for systems without 8.3 support and simplified the method to get the 8.3 name as a fallback.
See #12107 for details.
PR Summary
Adds a pure powershell means of achieving the workaround using a symbolic link.
Discourages use of the 8.3 short name path.
Explains why 8.3 short names may not be optimal.
Changes the command used to get the 8.3 short name to one that outputs the full path to pwsh.exe in 8.3 form.
Resolves Enable-SSHRemoting bug workaround improvement/modernization - Favor symlink over 8.3 and improve 8.3 fallback command #12107
PR Checklist
This PR is ready to go unless other edits are needed.