Auto Publish – main to live - 2025-07-31 22:00 UTC #12256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![learn-build-service-prod[bot]](https://avatars.githubusercontent.com/in/237442?s=80&v=4){kind=small}
Prior to this change, the authorization workflow used the PowerShell script parameter names and casing for the action parameter names. This worked for all previous parameters because PowerShell is case insensitive and the parameters were only one word. However, in #12181, we added the `authorized_accounts` parameter to the workflow. For GitHub Actions, we use `snake_case` for parameter names, where PowerShell best practice is to use `PascalCase`. PowerShell's case insensitivity meant that we were able to handle the prior parameters, which the workflow sends to the handler scripts as the `INPUT_<ParameterName>` environment variables. When we added `authorized_accounts`, the handler scripts were looking for `INPUT_AuthorizedAccounts`, which doesn't exist. This change updates the `Name` key for every defined parameter in the `verification/authorization/v1` workflow to match the actual workflow parameter name and casing.
Prior to this change, the authorization parameter handling didn't correctly handle an empty string for the `authorized_accounts` parameter. The casing for all other workflows used incorrect casing for workflow parameters, like `Message_Body` instead of `message_body`. This change: - Corrects the casing of all parameter handler entries. - Ensures that the parameter handler for `authorized_accounts` only passes the parameter to the action script when the input value is a non-empty string.
Prior to this change, the `verification/authorization/v1` workflow definition of the `authorized_accounts` parameter handler defined an empty scriptblock for the `IfNullOrEmpty` key to indicate that null/empty values are acceptable for this optional parameter. Instead, it shouldn't define the `IfNullOrEmpty` key-value pair at all. The `Get-ActionScriptParameter` helper function ignores null or empty values when the `IfNullOrEmpty` key isn't defined. This change removes the `IfNullOrEmpty` key-value pair from the `authorized_accounts` parameter handler definition.
learn-build-service-prod
bot
requested review from
michaeltlombardi and
sdwheeler
as code owners
|
Learn Build status updates of commit 4552e66: ✅ Validation status: passed
For more details, please refer to the build report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Auto Publish system to publish changes from the main branch to the live branch.