-
Notifications
You must be signed in to change notification settings - Fork 41
Updated the get-started articles as per SDK v2 changes #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Learn Build status updates of commit f4b0ca3:
|
File | Status | Preview URL | Details |
---|---|---|---|
microsoftgraph/docs-conceptual/navigating.md | View (graph-powershell-1.0 || graph-powershell-beta) | Details | |
microsoftgraph/docs-conceptual/authentication-commands.md | 💡Suggestion | View (graph-powershell-1.0 || graph-powershell-beta) | Details |
microsoftgraph/docs-conceptual/get-started.md | ✅Succeeded | View (graph-powershell-1.0 || graph-powershell-beta) |
microsoftgraph/docs-conceptual/navigating.md
- Line 8, Column 10: [Warning: ms-date-invalid - See documentation]
Value out of range for 'ms.date': '07/17/2023'. Must be a date in format M/D/YYYY, no more than 30 days from today.
microsoftgraph/docs-conceptual/authentication-commands.md
- Line 71, Column 230: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /powershell/module/microsoft.powershell.security/get-credential?view=powershell-7.3
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit e0eaa82:
|
File | Status | Preview URL | Details |
---|---|---|---|
microsoftgraph/docs-conceptual/navigating.md | View (graph-powershell-1.0 || graph-powershell-beta) | Details | |
microsoftgraph/docs-conceptual/authentication-commands.md | 💡Suggestion | View (graph-powershell-1.0 || graph-powershell-beta) | Details |
microsoftgraph/docs-conceptual/get-started.md | ✅Succeeded | View (graph-powershell-1.0 || graph-powershell-beta) |
microsoftgraph/docs-conceptual/navigating.md
- Line 8, Column 10: [Warning: ms-date-invalid - See documentation]
Value out of range for 'ms.date': '07/17/2023'. Must be a date in format M/D/YYYY, no more than 30 days from today.
microsoftgraph/docs-conceptual/authentication-commands.md
- Line 71, Column 230: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /powershell/module/microsoft.powershell.security/get-credential?view=powershell-7.3
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit 7b1d435: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 9c2bffd: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@timayabi2020 , @peombwa - requesting for your review of the SDK v2 updates. Thanks. |
@CarolKigoonya adding you to the reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @msewaweru for getting started on this! Please see my suggestions on the PR.
Thanks @msewaweru the documentation looks good. I only have one comment which I have raised an issue for, we need to mention how customers can get the access token to use for app only and delegated experiences inorder to use Invoke request. cc @peombwa and @timayabi2020 |
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
Learn Build status updates of commit e8bc400: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@peombwa, I committed your suggestions. Please approve if ok. |
No description provided.