-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Teams Shifts Connector Cmdlets to V2 APIs #10741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Teams Shifts Connector Cmdlets to V2 APIs #10741
Conversation
Learn Build status updates of commit cb39a2c:
|
Learn Build status updates of commit 618c439:
|
Learn Build status updates of commit 480607b:
|
Learn Build status updates of commit 150e2ae:
|
Learn Build status updates of commit bd9c831:
|
Learn Build status updates of commit b01fa02:
|
Learn Build status updates of commit ad5cec1:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the author metadata as indicated. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some non-critical suggestions.
Will some of these cmdlets be included in the next PS module release?
Thanks!
@tiburd Please merge this PR. Thanks |
@Shane-Malone |
@tiburd I believe that the get-help details are generated for cmdlets using the docs in this repo. These docs need to be merged prior to releasing the cmdlets to facilitate this. |
Learn Build status updates of commit df5ee39:
|
@Shane-Malone - Who, within the Magic org, are you collaborating with in regard to these updates? |
Learn Build status updates of commit fbee651:
|
Learn Build status updates of commit 08021a5:
|
@traya1 I am not collaborating with anyone in the magic org as these changes are related to cmdlets in the teams org |
@tiburd could you remove the draft tag and merge PR. The IC3 team has confirmed that docs are required to be merged before the release of the cmdlets. This is the same as has been done previously. |
@Shane-Malone After Thomas, our GitHub admin, approves, I'll proceed. cc: @traya1 |
The warning needs to be resolved prior to merging the PR. It's a requirement within the Magic org to not merge PRs with a build status with other than |
Learn Build status updates of commit d4c82e4:
|
Learn Build status updates of commit 25e811e:
|
@traya1 the validation is passing now. The source path for MAML to YAML files needed to be the yml file extension. |
[like] Thomas Raya (Aquent LLC) reacted to your message:
…________________________________
From: Shane-Malone ***@***.***>
Sent: Wednesday, April 26, 2023 9:11:45 PM
To: MicrosoftDocs/office-docs-powershell ***@***.***>
Cc: Thomas Raya (Aquent LLC) ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/office-docs-powershell] Update Teams Shifts Connector Cmdlets to V2 APIs (PR #10741)
@traya1<https://github.com/traya1> the validation is passing now. The source path for MAML to YAML files needed to be the yml file extension.
—
Reply to this email directly, view it on GitHub<#10741 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANEPBQSMXIZTZXSFGYXP35LXDGFRDANCNFSM6AAAAAAXC2Q35I>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.