Skip to content

adding docs for set-teamsenvironmentconfig and clear-teamsenvironment… #10764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 8, 2023
Merged

adding docs for set-teamsenvironmentconfig and clear-teamsenvironment… #10764

merged 11 commits into from
May 8, 2023

Conversation

VikneshMSFT
Copy link
Contributor

…config

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2173b5b:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

pbafna03
pbafna03 reviewed Apr 25, 2023
View reviewed changes
@yogkumgit yogkumgit self-assigned this Apr 26, 2023
@yogkumgit yogkumgit requested review from get-itips, a user and dariomws April 26, 2023 07:12
@yogkumgit
Copy link

@JohanFreelancer9

JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed Apr 26, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review - @VikneshMSFT, kindly commit the suggested changes. Many thanks.

get-itips
get-itips reviewed Apr 26, 2023
View reviewed changes
get-itips
get-itips suggested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @pbafna03 , otherwise people will open issues asking what this cmdlet is used for, please expand the explanation. thanks

dariomws
dariomws approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@dariomws dariomws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok after the suggestions are applied

JohanFreelancer9
JohanFreelancer9 suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VikneshMSFT, kindly commit the two pending suggested changes. Thanks.

@learn-build-service-prod
Copy link

Learn Build status updates of commit a6310c5:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

JohanFreelancer9
JohanFreelancer9 reviewed May 3, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed May 3, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 reviewed May 3, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 suggested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VikneshMSFT, some more (final) suggestions after the last round of edits, please.

VikneshMSFT and others added 8 commits May 4, 2023 11:05
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md
4775c9f 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md
ce4953e 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
110b997 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
97eba40 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
acf9fd0 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
c199354 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
e2ee31c 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
feefeaa 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT
Copy link
Contributor Author

@JohanFreelancer9 , addressed comments. Please approve and merge this change.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 4775c9f:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit feefeaa:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

JohanFreelancer9
JohanFreelancer9 reviewed May 4, 2023
View reviewed changes
JohanFreelancer9
JohanFreelancer9 suggested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @VikneshMSFT, one more, please.

@VikneshMSFT @JohanFreelancer9
Update teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
65801fc 
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@VikneshMSFT
Copy link
Contributor Author

Addressed comments. please merge.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 65801fc:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Clear-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@yogkumgit
Copy link

@get-itips @tseward

ghost
ghost reviewed May 5, 2023
View reviewed changes
teams/teams-ps/teams/Set-TeamsEnvironmentConfig.md
```powershell
Set-TeamsEnvironmentConfig -TeamsEnvironmentName TeamsChina

$cred=get-credential
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Move-CsUser work without modern authentication, or is Move-CsUser for on-prem SfB Server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move-CsUser is an SFB on-prem cmdlet and it works with modern authentication. It internall calls Connect-MicrosoftTeams in MicrosoftTeams module. This change is to make a generic way to call move-csuser for Gallatin, Airgap and future special clouds, instead of tightly coupling, SFB on-prem CU release and MicrosoftTeams module. We wanted a way to decouple these components, so we need not release new SFB on-prem CU just to support the special cloud scenario.

@yogkumgit
Copy link

@tiburd Please merge this PR. Thanks

@tiburd
Copy link
Contributor

tiburd commented May 8, 2023

@pbafna03
Do you want to approve this PR before it's merged?
Thanks!

@tiburd tiburd merged commit 59d5baa into MicrosoftDocs:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
5 more reviewers

@dariomws dariomws dariomws approved these changes

@get-itips get-itips get-itips approved these changes

@JohanFreelancer9 JohanFreelancer9 JohanFreelancer9 approved these changes

@pbafna03 pbafna03 pbafna03 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@yogkumgit yogkumgit

@tiburd tiburd

Labels
area:teams Microsoft submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VikneshMSFT @yogkumgit @tiburd @dariomws @get-itips @JohanFreelancer9 @pbafna03 @officedocspr2