Skip to content

Adding Teams Messaging Configuration Docs #12139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

michbrown-png
Copy link
Contributor

@michbrown-png michbrown-png commented Sep 27, 2024

Cmdlets are live on Teams PowerShell Module. The documentation was not available for customers

Review feedback:
https://github.com/padmagit77

Copy link

Learn Build status updates of commit d90833a:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMessagingConfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsTeamsMessagingConfiguration.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@michbrown-png michbrown-png changed the title Uploading Teams Messaging Configuration Adding Teams Messaging Configuration Docs Sep 27, 2024
@michbrown-png michbrown-png added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 27, 2024
@padmagit77 padmagit77 self-assigned this Sep 27, 2024
@padmagit77 padmagit77 added the In review PubOps is reviewing the pull request label Sep 27, 2024
@padmagit77
Copy link
Contributor

Hi @michbrown-png

Following are blocking issues that need to be resolved before we can merge:

Get-CsTeamsMessagingConfiguration.md, Set-CsTeamsMessagingConfiguration.md

  • Make all characters in the folder path and file name lowercase.
  • Add a TOC with the entries for the new articles

Reference

Criteria used for pull request reviews

Blocking

  • Names for new files and folders follow these guidelines: Use only lowercase, dashes, and numbers. Spaces and underscores are not allowed.
  • When a new article is added, the same PR must also contain at least one updated TOC with an entry for the new article. Exceptions are allowed when the file has ROBOTS: NOINDEX, NOFOLLOW in the metadata.

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.The PR is free of merge conflicts. For more information, see Resolve merge conflicts in Git and GitHub. The PR can't be merged. Sets expectation of who is responsible for resolving the conflict.

Thanks
Padma

@padmagit77 padmagit77 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Sep 27, 2024
@michbrown-png michbrown-png removed the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Sep 27, 2024
Copy link

Learn Build status updates of commit 5d96f9b:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMessagingConfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsTeamsMessagingConfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 1d63aa4:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMessagingConfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/set-csteamsmessagingconfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit d9777a8:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/get-csteamsmessagingconfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/set-csteamsmessagingconfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 329505b:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/get-csteamsmessagingconfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/set-csteamsmessagingconfiguration.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@michbrown-png
Copy link
Contributor Author

michbrown-png commented Sep 27, 2024

@padmagit77 - the changes were made. Please review

@michbrown-png michbrown-png added the Sign off The pull request is ready to be reviewed and merged by PubOps label Sep 27, 2024
@garycentric garycentric self-assigned this Sep 27, 2024
@garycentric garycentric added the In review PubOps is reviewing the pull request label Sep 27, 2024
@garycentric garycentric merged commit 6f0c275 into MicrosoftDocs:main Sep 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants