Skip to content

Update Grant-CsTeamsUpgradePolicy.md #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Conversation

revaldiv
Copy link
Contributor

@revaldiv revaldiv commented Jan 2, 2019

Lines 42 and 43 identity needs to include AndMeetings (SfBWithTeamsCollabAndMeetings and SfBWithTeamsCollabAndMeetingsWithNotify) the present document duplicates SfBWithTeamsCollab and SfBWithTeamsCollabWithNotify identities for the meeting modes. I changed to accurately reflect the proper identities.

Lines 42 and 43 identity needs to include AndMeetings (SfBWithTeamsCollabAndMeetings and SfBWithTeamsCollabAndMeetingsWithNotify) the present document duplicates SfBWithTeamsCollab and SfBWithTeamsCollabWithNotify identities for the meeting modes.  I changed to accurately reflect the proper identities.
@opbld31
Copy link

opbld31 commented Jan 2, 2019

OPS Build status updates of commit 36f1d75:

🕙 Preparing: average preparing time is 1 min(s) 13 sec(s)

@opbld32
Copy link

opbld32 commented Jan 2, 2019

OPS Build status updates of commit 36f1d75:

🕙 Incremental building: average incremental building time is 12 min(s) 23 sec(s)

@opbld34
Copy link

opbld34 commented Jan 3, 2019

OPS Build status updates of commit 36f1d75:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kenwith
Copy link
Member

kenwith commented Jan 9, 2019

@tomkau and @islubin - Just wanted to confirm if this change is OK to merge? Looks OK to me.

@revaldiv - thanks for taking the time to make the docs better, much appreciated!

@opbld33
Copy link

opbld33 commented Jan 10, 2019

OPS Build status updates of commit 0e4bfbb:

🕙 Preparing: average preparing time is 1 min(s) 13 sec(s)

@opbld34
Copy link

opbld34 commented Jan 10, 2019

OPS Build status updates of commit 0e4bfbb:

🕙 Incremental building: average incremental building time is 12 min(s) 22 sec(s)

@opbld33
Copy link

opbld33 commented Jan 10, 2019

OPS Build status updates of commit 0e4bfbb:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/Grant-CsTeamsUpgradePolicy.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@islubin
Copy link
Contributor

islubin commented Jan 10, 2019

@bjwhalen as owner of upgrade to review

@bjwhalen
Copy link
Contributor

Thanks for looping me in @islubin

The change looks good. this was a bug in a change I made when I added the sfbwithTEamsCollabAndMeetings modes. I added the rows to the table and the modle column is correct but I mistakenly didn't update the identity name.

@kenwith kenwith merged commit 6102454 into MicrosoftDocs:master Jan 10, 2019
@kenwith
Copy link
Member

kenwith commented Jan 10, 2019

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants