Skip to content

Fix SipSignallingPort param name #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2020
Merged

Fix SipSignallingPort param name #4589

merged 4 commits into from
Jan 9, 2020

Conversation

jasomr
Copy link
Contributor

@jasomr jasomr commented Dec 30, 2019

GB to US English - removing one 'L' from the SipSignallingPort param name

@opbld31
Copy link

opbld31 commented Dec 30, 2019

Docs Build status updates of commit 8f545fd:

🕙 Full build: the average full build time is 11 min(s) 52 sec(s), this is based on the last 1000 build(s) for this repository.

@opbld30
Copy link

opbld30 commented Dec 30, 2019

Docs Build status updates of commit 8f545fd:

⚠️ Validation status: warnings

File Status Preview URL Details
sharepoint/docs-conceptual/index.md ⚠️Warning View (sharepoint-ps) Details
sharepoint/docs-conceptual/overview.md ⚠️Warning View (sharepoint-ps) Details
skype/skype-ps/skype/New-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)
skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)

sharepoint/docs-conceptual/index.md

  • Line 122: [Warning] Link 'https://technet.microsoft.com/en-us/library/fp161362' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

sharepoint/docs-conceptual/overview.md

  • Line 38: [Warning] Link 'https://docs.microsoft.com/en-us/powershell/scripting/powershell-scripting?view=powershell-5.1' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 39: [Warning] Link 'https://technet.microsoft.com/en-us/scriptcenter/dd742419.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 40: [Warning] Link 'https://technet.microsoft.com/en-us/library/ee221100.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 49: [Warning] Link 'https://technet.microsoft.com/en-us/library/ee176927.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 51: [Warning] Link 'https://technet.microsoft.com/en-us/library/ee176828.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 52: [Warning] Link 'https://technet.microsoft.com/en-us/library/ee177028.aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld32
Copy link

opbld32 commented Jan 7, 2020

Docs Build status updates of commit 509d665:

🕙 Full build: the average full build time is 11 min(s) 52 sec(s), this is based on the last 1000 build(s) for this repository.

@opbld34
Copy link

opbld34 commented Jan 7, 2020

Docs Build status updates of commit 509d665:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/New-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)
skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld31
Copy link

opbld31 commented Jan 7, 2020

Docs Build status updates of commit 55d1750:

🕙 Full build: the average full build time is 11 min(s) 53 sec(s), this is based on the last 1000 build(s) for this repository.

@opbld32
Copy link

opbld32 commented Jan 7, 2020

Docs Build status updates of commit 55d1750:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/New-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)
skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@get-itips
Copy link
Contributor

Hello @jasomr
How are you?

I checked and SipSignallingPort is still a valid parameter/property

This fails:

image

This works
image

Am I missing something?

@opbld32
Copy link

opbld32 commented Jan 9, 2020

Docs Build status updates of commit fd03382:

🕙 Full build: the average full build time is 11 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

@opbld33
Copy link

opbld33 commented Jan 9, 2020

Docs Build status updates of commit fd03382:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/New-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)
skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kenwith
Copy link
Member

kenwith commented Jan 9, 2020

@jasomr - closing as it appears we aren't able to validate. Please reopen and let me know if we are missing something.

@kenwith kenwith closed this Jan 9, 2020
@jasomr
Copy link
Contributor Author

jasomr commented Jan 9, 2020

How it can be reopened? It was fixed in code just it takes ages the code reaches live …

@kenwith @get-itips

@officedocspr officedocspr reopened this Jan 9, 2020
@opbld31
Copy link

opbld31 commented Jan 9, 2020

Docs Build status updates of commit fd03382:

🕙 Full build: the average full build time is 11 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

@kenwith
Copy link
Member

kenwith commented Jan 9, 2020

@jasomr - ok got you, it reopens automatically if you reply. Maybe we can just add a note @get-itips that the spelling changed? I will go ahead and merge now so the reference here reflects the new code.

@opbld30
Copy link

opbld30 commented Jan 9, 2020

Docs Build status updates of commit fd03382:

✅ Validation status: passed

File Status Preview URL Details
skype/skype-ps/skype/New-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)
skype/skype-ps/skype/Set-CsOnlinePSTNGateway.md ✅Succeeded View (skype-ps)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kenwith kenwith merged commit 9eb96bc into MicrosoftDocs:master Jan 9, 2020
@get-itips
Copy link
Contributor

@jasomr - ok got you, it reopens automatically if you reply. Maybe we can just add a note @get-itips that the spelling changed? I will go ahead and merge now so the reference here reflects the new code.

Ok, I'll add a note 👍

@get-itips
Copy link
Contributor

Adding a note and referencing here the PR.

@jasomr Thank you for your contribution, please, take a look at this so in the future we do not risk rejecting your PRs not knowing you are from Microsoft 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants