Use Npm task #3
Merged
Use Npm task #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Npm task is better to use than a Script task because it correctly injects credentials and other config
|
@vijayma thoughts? This came from this question on SO. |
mikeharder
reviewed
Oct 31, 2018
|
Seems reasonable to me (with the |
|
@mchelen Can you update your PR with the two suggestions? DisplayName and the custom command for test? Thanks. |
|
Yup I will, thanks for the feedback.
…On Wed, Oct 31, 2018, 1:20 PM Vijay Machiraju ***@***.*** wrote:
@mchelen <https://github.com/mchelen> Can you update your PR with the two
suggestions? DisplayName and the custom command for test? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB342iBdd-EbWM7oaDlRJNrJ5vfvXcrks5uqdvfgaJpZM4WvMIo>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Npmtask is better to use than ascriptcommand because it correctly injects credentials and other config