-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add CREATE USER
on the master database and cosmetic care
#10041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CREATE USER
on the master database and cosmetic care
#10041
Conversation
@segovoni : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit e1f20b5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@segovoni Thanks for taking the time to create this pull request and suggest these changes. There's a good add here about the Entra auth.
Some of these cosmetic changes are fine. We try to avoid unnecessary horizontal space - would rather a taller query than wide, so adding extra spaces is most a nuisance for folks who might have to horizontally scroll to read. Please revert and accept my suggested commits, and please update the ms.date metadata, and then we can move forward.
When merged, your GitHub name will appear in the public list of contributors on this page. Appreciate your time and attention here! Your efforts make the docs better for everyone, and we really do appreciate high quality contributions like this.
Co-authored-by: William Assaf MSFT <74387232+WilliamDAssafMSFT@users.noreply.github.com>
Learn Build status updates of commit 2be52ec: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: William Assaf MSFT <74387232+WilliamDAssafMSFT@users.noreply.github.com>
Learn Build status updates of commit 5aa61ca: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7f5b3c0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 37f5861: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@WilliamDAssafMSFT Thanks for your suggestions, they make sense. I confirmed your suggestions and updated Please let me know if everything is OK and if it is able to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
#sign-off
@WilliamDAssafMSFT, you can only sign off in the main PR conversation, not in review comments. |
#sign-off |
Thanks again @segovoni. Your commits will be merged and this article update is in flight. Thanks again for this feedback, your suggestions help improve our documentation. |
Learn Build status updates of commit 88293b8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#sign-off |
PR 10041 has been merged from segovoni:segovoni/elastic-jobs-umi-auth to MicrosoftDocs:live by v-dirichards. |
Create a user on the master database mapped to a login, it prevents the error:
Failed to determine members of SqlServerTarget (server name 'azure-sql-...', server location 'azure-sql-...'): The server principal "926e2a2b...@1f36c249..." is not able to access the database "master" under the current security context. Cannot open database "master" requested by the login. The login failed. Login failed for user '926e2a2b...@1f36c249...'.